-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Add last_modified_time to account responses #2528
Conversation
8ed254b
to
14a12b7
Compare
@bartekn PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I think we should update the changelog with a note about the new last_modified_time
field in the account response
@tamirms I added it, but I wasn't sure what format to follow for unreleased changes in master. PTAL |
356107c
to
83d9687
Compare
Also, get rid of the account query consistency check, comparing Horizon's DB and Core's DB.
83d9687
to
bd175ed
Compare
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add
last_modified_time
to account responses (making it consistent with offers).last_modified_time
is the closing time of the most recent ledger in which the account was modified.Also, get rid of the account query consistency check, comparing Horizon's DB and Core's DB.
Why
Fixes #1945
Known limitations
It adds an additional DB query per account which can negatively affect performance.