services/horizon: Ignore db.ErrCanceled and ctx.Canceled returned by verifyState. #2366
+79
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
Mar 9, 2020
|
@bartekn I added the helper. |
bartekn
approved these changes
Mar 9, 2020
abuiles
force-pushed
the
handle-db-err-context-cancelled
branch
from
9cd34eb to
2b4765a
Compare
If the system is shutdown during state verification, there is a warning in the log showing ``` WARN[2020-02-04T18:14:19.987+01:00] State verification errored err="addAccountsToStateVerifier failed: Error running history.Q.GetAccountsByIDs: select failed: context canceled" pid=99452 service=expingest ``` If the system is being shutdown gracefully which is the case when we get this errors, then we shouldn't log an error. Fix stellar#2224
abuiles
force-pushed
the
handle-db-err-context-cancelled
branch
from
2b4765a to
09d18fb
Compare
abuiles
force-pushed
the
handle-db-err-context-cancelled
branch
from
09d18fb to
41bc28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Ignore db.ErrCanceled and ctx.Canceled returned by verifyState.
Fix #2224
Why
If the system is shutdown during state verification, there is a warning inthe log showing
If the system is being shutdown gracefully which is the case when we
get this errors, then we shouldn't log an error.
Fix #2224
Known limitations
[TODO or N/A]