Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/ingest/io: Remove support for TransactionMeta.V=0 #2101

Merged

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 9, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit removes support for ingesting TransactionMeta.V=0 in io.LedgerTransaction.GetChanges.

Close #2097.

Why

The code generating V0 meta was changed in stellar-core but without upgrading the V param. Some V0 meta has only one LEDGER_ENTRY_STATE emitted only when a ledger entry is first modified in a ledger but others add it before every LEDGER_ENTRY_UPDATE and LEDGER_ENTRY_REMOVED. It looks like the code to parse meta to support both cases should be possible but since transaction meta in protocol version <10 can be incomplete (see #1902) users still need to switch to V2 to be able to parse it.

See:

Known limitations

TransactionMeta generated by the older versions of stellar-core will not be supported but the current code is in LedgerTransaction.GetChanges is broken anyway.

@bartekn bartekn merged commit 10480c7 into stellar:release-horizon-v0.25.0 Jan 10, 2020
@bartekn bartekn deleted the remove-support-txmeta-v0 branch January 10, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants