exp/ingest/ledgerbackend: Ensure tx meta is v2 when getting protocol version <10 ledgers #2099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit adds a code that checks if tx meta version is v2 for protocol version <10 ledgers.
Close #2095.
Why
As explained by @MonsieurNicolas in #1902:
It's possible that users will use stellar-core without
SUPPORTED_META_VERSION=2
and in such case ingestion system can process state changes incorrectly.Known limitations
I realized we don't have tests in
exp/ingest/ledgerbackend
. Would be great to add them in a separate PR.