Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/ingest/ledgerbackend: Ensure tx meta is v2 when getting protocol version <10 ledgers #2099

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 9, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit adds a code that checks if tx meta version is v2 for protocol version <10 ledgers.

Close #2095.

Why

As explained by @MonsieurNicolas in #1902:

There is some missing meta in protocol version older than version 10. This impacts transactions with one time signers (that get removed after operations in v9 and earlier; and during signature verification in v10 and later). Those changes are invisible in the meta which may confuse certain ingestion processors that keep track of signers on accounts.

It's possible that users will use stellar-core without SUPPORTED_META_VERSION=2 and in such case ingestion system can process state changes incorrectly.

Known limitations

I realized we don't have tests in exp/ingest/ledgerbackend. Would be great to add them in a separate PR.

Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bartekn bartekn merged commit 7236520 into stellar:release-horizon-v0.25.0 Jan 9, 2020
@bartekn bartekn deleted the require-meta-v2-for-protocol-pre-10 branch January 9, 2020 21:55
bartekn added a commit that referenced this pull request Aug 20, 2020
Due to a bug in Stellar-Core (more info in #2099) we check if the meta
version is at least 2 for protocol version < 10. However, some backend
like `HistoryArchiveBackend` do not return tx meta. For such backends we
should skip the check. The check is safe because each transaction has
fee changes associated with it so it will be empty if no meta is
available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants