Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Use context from session in sqlx functions #1977

Merged
merged 4 commits into from
Dec 2, 2019

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Nov 25, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #1950 , #1974

Use the context in db.Session when executing sql queries and statements on the session connection. A consequence of this change is that the session context is no longer optional.

Why

It should be possible to pass context.Context to set timeout for queries sent to a database. This is to prevent long running queries to occupy DB connection for a long period of time.

Known limitations

[TODO or N/A]

@tamirms tamirms changed the title Use context from session in sqlx functions all: Use context from session in sqlx functions Nov 25, 2019
@tamirms tamirms requested a review from bartekn November 25, 2019 19:11
@tamirms tamirms marked this pull request as ready for review November 25, 2019 19:11
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! FYT, registered context.DeadlineExceeded to return 504 responses in ece2b85. Adding @accordeiro to reviewers because it touches his app. Alex, when you're back please check it out.

@bartekn bartekn requested a review from accordeiro November 28, 2019 16:35
Copy link
Member

@accordeiro accordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticker part looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants