Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/actions: Update payload for "Accounts For Signers" end-point. #1876

Merged
merged 4 commits into from
Oct 25, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 24, 2019

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Summary

Account for signers was using a partial representation of accounts since we didn't have all the necessary information in the database to build the full representation. Since #1819 we are now ingesting account data and can return all the fields related with an account. This PR updates the end-point making it consistent with the results when fetching a single account or filtering accounts by a given trustline. Fixes #1875

Goal and scope

  • Update payload in account for signers.

Summary of changes

  • Add new method to history, so we can fetch account entries from a signer.

Known limitations & issues

What shouldn't be reviewed

@cla-bot cla-bot bot added the cla: yes label Oct 24, 2019
@abuiles abuiles requested review from tamirms and bartekn October 24, 2019 17:45
@abuiles abuiles merged commit 8c07c2b into release-horizon-v0.23.0 Oct 25, 2019
@abuiles abuiles deleted the update-accounts-signer-filter-result branch October 25, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants