Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use strings.Contains() instead of regex.Match() when populating HAL t… #1582

Closed
wants to merge 1 commit into from
Closed

use strings.Contains() instead of regex.Match() when populating HAL t… #1582

wants to merge 1 commit into from

Conversation

oryband
Copy link
Contributor

@oryband oryband commented Aug 11, 2019

Second PR following discussion in #1446 and #1504 (please see these discussions). This time only improving the performance of HAL response construction using PopulateTemplated() without involving calling Go regexp package. This improves response performance.

@oryband
use strings.Contains() instead of regex.Match() when populating HAL t…
2417ac8 
…emplates

This improves performances due to less complex string processing.

fixes stellar#1446
@oryband oryband mentioned this pull request Aug 11, 2019
Closed
@abuiles abuiles mentioned this pull request Jul 10, 2020
Merged
7 tasks
@abuiles
Copy link
Contributor

abuiles commented Jul 10, 2020

@oryband I cherry-pick your changes in #2806 - so it's up to date with master

@abuiles abuiles closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oryband @abuiles