Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizon: meta should be returned as null rather than empty when SKIP_TXMETA enabled #5221

Closed
mollykarcher opened this issue Feb 22, 2024 · 2 comments
Closed

horizon: meta should be returned as null rather than empty when SKIP_TXMETA enabled #5221

mollykarcher opened this issue Feb 22, 2024 · 2 comments
Assignees
@sreuland
Labels
rpc-sdk-scrum
Milestone
Sprint 44

Comments

@mollykarcher
Copy link
Contributor

Original issue here #5189

Our original implementation of this had the API returning valid but empty metas. This seems to have been a miscommunication as the product request was for the API to return null. We should update the API responses to return null rather than empty metas.
@mollykarcher mollykarcher added this to the Sprint 44 milestone Feb 22, 2024
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Feb 22, 2024
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Feb 22, 2024
@mollykarcher
Copy link
Contributor Author

To be released in 2.28.4

@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum Mar 4, 2024
sreuland added a commit to sreuland/go that referenced this issue Mar 4, 2024
@sreuland
stellar#5221: return null txmeta in api tx resource model when SKIP_T…
03968f5 
…XMETA
@sreuland sreuland mentioned this issue Mar 4, 2024
Merged
7 tasks
sreuland added a commit to sreuland/go that referenced this issue Mar 4, 2024
@sreuland
stellar#5221: return null txmeta in api tx resource model when SKIP_T…
a45dca2 
…XMETA
sreuland added a commit to sreuland/go that referenced this issue Mar 4, 2024
@sreuland
stellar#5221: fixed unit test for singleton usage of resourceadpater
15df627
sreuland added a commit to sreuland/go that referenced this issue Mar 4, 2024
@sreuland
stellar#5221: updated changelogs on protocol and horizon
0f11ad2
sreuland added a commit to sreuland/go that referenced this issue Mar 5, 2024
@sreuland
stellar#5221: use functional composition to pass SKIP_TXMETA down to …
0e767ad 
…resource adapters instead of static dependency injection pattern
@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Mar 5, 2024
sreuland added a commit to sreuland/go that referenced this issue Mar 6, 2024
@sreuland
stellar#5221: use empty string for result_meta_xdr and omitempty on j…
325d0ba 
…son mapping, so field is absent from json
sreuland added a commit to sreuland/go that referenced this issue Mar 6, 2024
@sreuland
stellar#5221: fixed client unit test
e5ef575
urvisavla pushed a commit that referenced this issue Mar 6, 2024
@sreuland
services/horizon: return null txmeta in api model when SKIP_TXMETA en…
3e82931 
…abled (#5228)

* #5221: fixed unit test for singleton usage of resourceadpater

* #5221: updated changelogs on protocol and horizon

* #5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern

* #5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json

* #5221: fixed client unit test
Shaptic pushed a commit to Shaptic/go that referenced this issue Mar 12, 2024
@sreuland @Shaptic
services/horizon: return null txmeta in api model when SKIP_TXMETA en…
1a6cee2 
…abled (stellar#5228)

* stellar#5221: fixed unit test for singleton usage of resourceadpater

* stellar#5221: updated changelogs on protocol and horizon

* stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern

* stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json

* stellar#5221: fixed client unit test
Shaptic pushed a commit to Shaptic/go that referenced this issue Mar 12, 2024
@sreuland @Shaptic
services/horizon: return null txmeta in api model when SKIP_TXMETA en…
1279381 
…abled (stellar#5228)

* stellar#5221: fixed unit test for singleton usage of resourceadpater

* stellar#5221: updated changelogs on protocol and horizon

* stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern

* stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json

* stellar#5221: fixed client unit test
@sreuland
Copy link
Contributor

this went out in 2.29.0 release.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
Sprint 44
Development

No branches or pull requests
2 participants
@mollykarcher @sreuland