Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/lighthorizon: consistent error formatting and semantics #4472

Closed
sreuland opened this issue Jul 21, 2022 · 1 comment
Closed

exp/lighthorizon: consistent error formatting and semantics #4472

sreuland opened this issue Jul 21, 2022 · 1 comment
Assignees

Comments

@sreuland
Copy link
Contributor

sreuland commented Jul 21, 2022

What problem does your feature solve?

  • light horizon should re-use horizon problems package for overall consistent error message formatting on web service endpoints.
  • error responses should have their http status code verified, correct 4XX or 5XX for the error context.
  • For /accounts/{account_id}/... endpoints, if account_id doesn't exist in the underlying index, it returns empty response, is that acceptable or should it return 404, it's dependent on the exported index state, there is no current state of the network available that can provide the deterministic 'not found'

What would you like to see?

Good error descriptions and correct 4XX or 5XX http status codes on error responses from web endpoints.

What alternatives are there?

@Shaptic
Copy link
Contributor

Shaptic commented Aug 17, 2022

Closed by #4542.

@Shaptic Shaptic closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants