Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /assets endpoint using experimental ingestion #1765

Closed
bartekn opened this issue Sep 20, 2019 · 2 comments
Closed

Implement /assets endpoint using experimental ingestion #1765

bartekn opened this issue Sep 20, 2019 · 2 comments
Assignees
@tamirms
Labels
horizon
Milestone
Horizon 0.23.0

Comments

@bartekn
Copy link
Contributor

bartekn commented Sep 20, 2019 •
edited
Loading

Here's the initial idea how to build it using expingest:

  • We create a new state processor that saves trust lines to Horizon DB. We may need to split DatabaseProcessor into multiple processors sharing the same DB transaction as it's getting too big. When updating DB is done it creates aggregations and saves them to another table.
  • We create a new ledger processor that updates trust lines in Horizon DB using txmeta. We may finally use pipeline.Store to forward assets that have changed to the next processor that will aggregate data for these assets only.
  • Trust lines table will be also useful for Horizon api find all trustees to an asset issuing account #442.
@bartekn bartekn added this to the Horizon 0.22.0 milestone Sep 20, 2019
@bartekn bartekn mentioned this issue Sep 23, 2019
Closed
34 tasks
@bartekn bartekn mentioned this issue Sep 30, 2019
Merged
7 tasks
@tamirms tamirms self-assigned this Oct 1, 2019
bartekn added a commit that referenced this issue Oct 8, 2019
@bartekn
services/horizon/expingest: Update DatabaseProcessor with trust lines (…
705917b 
…#1794)

This commit adds trust lines to ingestion pipeline.

In #1765, #1766 and #442 we need trust lines in Horizon DB to serve the
requests. This commit is adding a code needed by all of the issues
above.

List of changes:

* Adds a new migration file adding a new `trust_lines` table.
* Updates `db2/history` package with trust lines related interfaces and
structs.
* Updates `DatabaseProcessor` to process trust lines in state and ledger
pipelines.
@tamirms
Copy link
Contributor

tamirms commented Oct 10, 2019

The endpoint is implemented in #1824 . However, the PR depends on #1810 and #1819 . Once both those PRs are merged, #1824 can be reviewed and merged

@tamirms tamirms mentioned this issue Oct 16, 2019
Merged
7 tasks
@bartekn
Copy link
Contributor Author

bartekn commented Oct 18, 2019

Closed in #1824.

@bartekn bartekn closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirms tamirms

Labels
horizon
Projects
None yet
Milestone
Horizon 0.23.0
Development

No branches or pull requests
2 participants
@bartekn @tamirms