services/horizon: Update default for --captive-core-use-db to true (#…

…4877) * 4856: Update default for --captive-core-use-db to true * Update CHANGELOG.md
stellar · Jun 6, 2023 · da99d59 · da99d59
1 parent b060996
commit da99d59
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/services/horizon/CHANGELOG.md b/services/horizon/CHANGELOG.md
@@ -5,6 +5,11 @@ file. This project adheres to [Semantic Versioning](http://semver.org/).
 
 
 ## Unreleased
+### Changes
+### Breaking Changes
+- Modify the default value of `--captive-core-use-db` to true ([4856](https://github.com/stellar/go/issues/4856))
+  - This updates the default behavior of captive core to start in on-disk mode.
+  - To continue using the previous in-memory mode, explicitly set the `--captive-core-use-db` flag to false
 
 ## 2.24.1
 

diff --git a/services/horizon/internal/flags.go b/services/horizon/internal/flags.go
@@ -177,7 +177,7 @@ func Flags() (*Config, support.ConfigOptions) {
 		&support.ConfigOption{
 			Name:        CaptiveCoreConfigUseDB,
 			OptType:     types.Bool,
-			FlagDefault: false,
+			FlagDefault: true,
 			Required:    false,
 			Usage: `when enabled, Horizon ingestion will instruct the captive
 			              core invocation to use an external db url for ledger states rather than in memory(RAM).\n 
@@ -736,9 +736,6 @@ func ApplyFlags(config *Config, flags support.ConfigOptions, options ApplyOption
 		if config.StellarCoreDatabaseURL != "" {
 			return fmt.Errorf("Invalid config: --%s passed but --ingest not set. ", StellarCoreDBURLFlagName)
 		}
-		if config.CaptiveCoreConfigUseDB {
-			return fmt.Errorf("Invalid config: --%s has been set, but --ingest not set. ", CaptiveCoreConfigUseDB)
-		}
 	}
 
 	// Configure log file