Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction records should be created upon first POST #22

Closed
msfeldstein opened this issue Dec 2, 2019 · 2 comments
Closed

Transaction records should be created upon first POST #22

msfeldstein opened this issue Dec 2, 2019 · 2 comments
Assignees
@JakeUrban
Labels
bug Something isn't working

Comments

@msfeldstein
Copy link
Contributor

When a client POSTs to /transaction/withdraw/interactive or /transaction/deposit/interactive it should create a persisted Transaction object to the db. Currently we create an ephemeral UUID, and then upon submission of the interactive webapp we use that UUID to actually create a Transaction object. The problem here is that since there's no record, the /transactions endpoint is empty so it looks like no transaction has been started. It's even more confusing since the transaction originally returned does have an ID so it seems like we should be able to query it, but can't.
@msfeldstein msfeldstein added the bug Something isn't working label Dec 2, 2019
@JakeUrban JakeUrban self-assigned this Dec 4, 2019
@JakeUrban
Copy link
Contributor

This will be released as a part of the Form Integrations functionality #27

JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 4, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
ec923d5
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 4, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
a440f77
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 4, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
d257b73
@JakeUrban JakeUrban mentioned this issue Dec 4, 2019
Merged
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 4, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
9ea389c
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 5, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
5aa2ef8
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 6, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
78cd76b
JakeUrban added a commit that referenced this issue Dec 6, 2019
@JakeUrban
Fixed issues #22 and #19 (#31)
c26858e 
* Fixed issues #22 and #19

* Bumped version and updated Pipfile

* Mark created transactions as incomplete
JakeUrban added a commit to JakeUrban/django-polaris that referenced this issue Dec 6, 2019
@JakeUrban
Fixed issues stellar#22 and stellar#19
b67675f
@JakeUrban
Copy link
Contributor

Released with 0.9.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeUrban JakeUrban

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msfeldstein @JakeUrban