Update node version to node20

[ryudaitakai]

Node20 was added to Actions Runner on v2.308.0.
Node16 will be end of life on 11 Sep 2023.

This PR updates the default runtime to node20, rather than node16

[stefanzweifel]

Thanks!

I will merge and tag a new version of this in a couple of weeks.
Users might not run the latest version of GitHub Actions runner and need to catch up.

Or maybe even tag a new major version. 🤔

See the discussion we had the last time we switched the used runtime. #246

[ryudaitakai]

(I didn't know that it was possible to point v4 back to a non-latest version and also about GHES...!)

I think It's better to do like last time you upgrade the node.js version. #246
Node.js 20 will enter long-term support (LTS) in October so it's good to wait for 2 or 3 months.

[vosscodes]

👋 thanks for taking this on!

IMO it would be good to release a new major version as done in other actions like those used to configure AWS credentials which would allow this to be released now rather than in a few weeks or months :)

[stefanzweifel]

@vosscodes Thanks for the feedback. Does the lack of merging this PR block you in any way?

I know that I could simply create a new major version; but IMO I don't like tagging a new major version if the only thing that changes is the node version the action runs on; which isn't even relevant for this package as node just triggers a bash script.
(I mostly work in PHP where breaking changes made in packages are relatively rare)

But maybe that's just something I have to deal with and release a new major version every 12 months without changing the API of the Action. 🤔

[vosscodes]

nope! I wouldn't say it blocks us at all, and you should feel free to hold off as you see fit. we're very strict on the things we run, even when it's a github action that clearly is not at risk by being on node 16.

I definitely agree that this:

But maybe that's just something I have to deal with and release a new major version every 12 months without changing the API of the Action.

is ridiculous and should never be a real thing that happens 😅

we've noted this as an exception for now, but it'd still be helpful to figure out a way to ensure we have an upgrade path to new LTS node versions when released - which, for what it's worth, node 20 security support would give you 30 months without needing a new major version upgrade :)

[stefanzweifel]

@vosscodes Thanks for understanding my reluctancy here.

Will probably bite the bullet here and create a new major version tomorrow.

[vosscodes]

appreciate you understanding us as well - we're on board with whatever you decide to go with!