Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with 23.3.0 #159

Closed
simasch opened this issue Dec 15, 2022 · 13 comments
Closed

Doesn't work with 23.3.0 #159

simasch opened this issue Dec 15, 2022 · 13 comments
Labels
bug Something isn't working

Comments

@simasch
Copy link

simasch commented Dec 15, 2022

When using Fullcalendar with Vaadin 23.3.0 the application no longer starts.
In the browser log I see

(anonymous) @ index.ts:32
vdom.js:3 Uncaught (in promise) Error: Please import the top-level fullcalendar lib before attempting to import a plugin.
    at vdom.js:3:11

@aetasoul
Copy link
Collaborator

Can you provide more details?

Java version
Code to reproduce the problem

@simasch
Copy link
Author

simasch commented Dec 15, 2022

@aetasoul Please find a reproducible example here: https://github.com/simasch-scratches/datapicker-validation/tree/fullcalendar-issue

Make sure you checkout the branch fullcalendar-issue

@aetasoul
Copy link
Collaborator

I'll check it

@stefanuebe
Copy link
Owner

Might be a problem regarding the time, when the plugins are registered. Not sure why this comes up with 23.3, but it seems to be a known issue. At least stackoverflow provides a lot of Q&A regarding this. Trying to reproduce and test those.

@stefanuebe
Copy link
Owner

stefanuebe commented Dec 15, 2022

primefaces/primevue#1211

In my minimal sample it helped to add the line before the Calendar import

import '@fullcalendar/core';

Might be necessary to also add

import '@fullcalendar/core/vdom';

but at least for me now it seemed to work. Will add that for now to fix that issue (I hope it does not break anything else :D)

stefanuebe added a commit that referenced this issue Dec 15, 2022
Added explicit version for spring maven addon due to 3.x issues. Updated to Vaadin 4.9.3

Version 4.1.4
@stefanuebe
Copy link
Owner

Released with 4.1.4. Please countercheck, if it also works for you

@stefanuebe stefanuebe added the bug Something isn't working label Dec 15, 2022
@simasch
Copy link
Author

simasch commented Dec 15, 2022

@stefanuebe No doesn't work for me

Please find a reproducible example here: https://github.com/simasch-scratches/datapicker-validation/tree/fullcalendar-issue
Make sure you checkout the branch fullcalendar-issue

@stefanuebe
Copy link
Owner

Yes, you are right. On the first load I still get the issue, but on subsequent calls it does not occur anymore. That is really strange.

@stefanuebe
Copy link
Owner

Can you try if it works for you, when you change the imports in the full-calendar.js to

import '@fullcalendar/core/vdom'; 
import '@fullcalendar/core';

@simasch
Copy link
Author

simasch commented Dec 15, 2022

@stefanuebe Yes with this imports it works!

@stefanuebe
Copy link
Owner

Alright, then 4.1.5 is the version to go

stefanuebe added a commit that referenced this issue Dec 15, 2022
Version 4.1.5
@simasch
Copy link
Author

simasch commented Dec 15, 2022

Thanks for your very fast support!

@simasch
Copy link
Author

simasch commented Dec 15, 2022

I've opened a new issue with the problem added in 4.1.5
#160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants