Fix x-kubernetes-preserve-unknown-fields path mismatch
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
changed the title
x-kubernetes-preserve-unknown-fields path mismatch
If an array type is present in the CRD, the `parentPath` function fails to compose the full path to the spec parent for all fields declared after the array. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
test-nested-spec
branch
from
1af7d46 to
e02da77
Compare
For CRDs with arrays the `parentPath` function doesn't walk back to the spec. To not miss `x-kubernetes-preserve-unknown-fields` we do partial matching which could open more fields than desired if the field names overlap. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CRDs with arrays the
parentPathfunction doesn't walk back to the spec, as a workaround, to not missx-kubernetes-preserve-unknown-fieldswe do partial matching which could open more fields than desired if the field names overlap.Fix: #278