Use native polyfill on Chrome and Node.js v0.12

[piranna]

On v8 based Javascript engines, the check for using the native Polyfill implementations fails because the check

Object.prototype.toString.call(P.resolve())

return [object Object] instead of the expected [object Promise], that only happens to be on Firefox. I think this check should be less strict or use other condition so v8 native Promises can be used.

[yethee]

And not has the static method cast.

[piranna]

And not has the static method cast.

No they don't have it (at least Chromium 41 and Node.js v0.12.2)

[yethee]

I mean that the native Promise of V8 has no method cast.

[piranna]

Firefox 37 doesn't have it either...

[lvscar]

#99 fixed it , but not have merged .

[piranna]

Definitely a better checker, let's see if it got merged :-)
El 22/04/2015 04:39, "lvs(zikuan.ly)" notifications@github.com escribió:

#99 #99 fixed it , but
not have merged .

—
Reply to this email directly or view it on GitHub
#111 (comment)
.

[klimashkin]

Object.prototype.toString.call(Promise.resolve())
"[object Object]"

Chrome 45.0.2428.0 Canary
V8 4.5.45

Such method seems like suits better:

typeof Promise !== "undefined" && Promise.toString().indexOf("[native code]") > -1

http://stackoverflow.com/posts/22517133/revisions

[stefanpenner]

There are still some serious bugs in the v8 promise implementation. Some timing and extra side effects. So we are luckily that the current check still fails. Hopefully they fix the other issues before they fix the toString

[klimashkin]

Could you give an examples of v8 bugs?

[stefanpenner]

It doesn't handle inheritance correctly And resolve isn't correct. Which results in observable ordering differences https://code.google.com/p/v8/issues/detail?id=4162&q=Promise&colspec=ID%20Type%20Status%20Priority%20Owner%20Summary%20HW%20OS%20Area%20Stars

[stefanpenner]

For some reason I can't find the inheritance issue I reported... Strange I have clear memory of it being responded to as well..

[stefanpenner]

found it: https://code.google.com/p/chromium/issues/detail?id=493797

[koba04]

I think it would be better to check to be 'thenable' like below.

typeof Promise === 'function' && typeof new Promise(function() {}).then === 'function'

[stefanpenner]

I think it would be better to check to be 'thenable' like below.

but the promise implementations that don't match ^^ have bugs still. Why loosen the constraint, and introduce bugs...

[NoelAbrahams]

@stefanpenner,

I see the point about the couple of bugs in Chrome's implementation. However, they may well fix the [object Promise] bug before fixing those. Then people will start defaulting to the native implementation without their knowledge.