forked from emberjs/ember.js
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes: Safari's 'double finally on error bug'
Bug Demo: http://jsbin.com/usoquy/1/edit known to be an issue in: * Safari 6.0.2 * iOS 6 mobile safari * maybe others Turns out certain versions of safari 6.0.2 and potentially other webkits, will execute finally twice, if an error in finally is thrown. Interestingly the error will only be thrown once. But the code up until the error is thrown, will be executed twice. Although strange, it is rare during normal ideal execution that this causes real issues, but when it does, it is quite frustrating to debug. Two new utility methods provide the 'safe' workaround: Ember.tryFinally(tryable, finalizer); Ember.tryCatchFinally(tryable, catchable, finalizer); These helpers try to abide by the languages try/catch/finally semantics.
- Loading branch information
1 parent
77df9b4
commit 917da11
Showing
8 changed files
with
363 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.