Add FORTIFY_SOURCE fix and pin package versions #80
Conversation
danielksato
commented
Apr 14, 2024
danielksato
commented
As described in stefanpartheym#77 and stefanpartheym#79, FORTIFY_SOURCE is needed for Cmake to work on icamerasrc and intel-ipu36-camera-hal. Additionally, recent upstream releases have broken several dependencies. While I'm hoping the recent flurry of activity upstream means support for kernel 6.7+ is on the way, these workarounds should keep us running for now.
|
Marking this as a draft until someone confirms that my updated PKGBUILD for |
intel-ipu6-dkms-git/PKGBUILD
Outdated
| license=('unknown') | ||
| depends=('dkms' 'intel-ivsc-firmware') | ||
| provides=('intel-ivsc-driver-dkms-git', 'intel-ipu6-dkms-git') | ||
| conflicts=('intel-ivsc-driver-dkms-git', 'intel-ipu6-dkms-git') |
There was a problem hiding this comment.
AFAICT these , (commas in provides and conflicts) are invalid characters
|
I tried this branch (removing the commas I mentioned) and I'm getting: Any pointers? |
|
@petobens |
|
Everything working now. Great work! Thanks! |
|
Happy to help.
I think before I take this out of draft, I'd like to see confirmation that
it works for a fresh install, and that it works when installing over an
existing install.
…On Mon, Apr 15, 2024 at 8:24 AM Pedro Ferrari ***@***.***> wrote:
Everything working now. Great work! Thanks!
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJXLIIWXB2LPZOVFQ7KZZ3Y5PIKBAVCNFSM6AAAAABGGJPEM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWHA2DSMBQGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@danielksato I confirm that it works with me. @stefanpartheym May be it is feasible to make a new branch out of this PR, because the updates of the upstream dependencies are breaking the setup. So, having a branch that pinpoint the commits known to work is IMO a good idea. |
|
@elhossary did this work for you on a fresh install, or were you installing over an existing one? |
|
fresh install |
|
Cool, I'll mark it ready for review. |
|
Not wanting to delay the merging of this PR, since it makes everything build again for me (latest manjaro, kernel and on X1 Carbon Gen 11 21HMCTO1WW with an ov2740 sensor. Any clues on what might be wrong? I tried wiping out my |
|
Did you try re-running `install.sh` with the `-as` flags?
…On Tue, Apr 16, 2024, 9:21 AM lukemarsden ***@***.***> wrote:
Not wanting to delay the merging of this PR, since it makes everything
build again for me (latest manjaro, kernel 6.6.27-1-MANJARO), but I'm
seeing no video, v4l2-relayd giving me:
[...]
Apr 16 15:15:15 hope sh[4651]: [04-16 15:15:15.902] CamHAL[ERR] Failed to find DevName for cameraId: 0, get video node: ov13b10 , devname: /dev/v4l-subdev1
Apr 16 15:15:15 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] Get entity fail for calling getEntityById
Apr 16 15:15:15 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] Get entity fail for calling getEntityById
Apr 16 15:15:15 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] setup Link ov13b10 [-1:0] ==> Intel IPU6 CSI-2 [-1x0] enable 1 failed.
Apr 16 15:15:15 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] set MediaCtlConf McLink failed: ret = -1
Apr 16 15:15:20 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] set up mediaCtl failed
Apr 16 15:15:20 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] @configure Device Configure failed
Apr 16 15:15:20 hope sh[4651]: [04-16 15:15:15.908] CamHAL[ERR] failed to config streams.
and sudo gst-launch-1.0 icamerasrc ! autovideosink giving:
[04-16 15:19:42.125] CamHAL[INF] (null), media format in tuning: 0, media format for aic 0.
[04-16 15:19:42.125] CamHAL[ERR] Failed to find DevName for cameraId: 0, get video node: ov13b10 , devname: /dev/v4l-subdev1
Pipeline is live and does not need PREROLL ...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
[04-16 15:19:42.133] CamHAL[ERR] Get entity fail for calling getEntityById
[04-16 15:19:42.133] CamHAL[ERR] Get entity fail for calling getEntityById
[04-16 15:19:42.133] CamHAL[ERR] setup Link ov13b10 [-1:0] ==> Intel IPU6 CSI-2 [-1x0] enable 1 failed.
[04-16 15:19:42.133] CamHAL[ERR] set MediaCtlConf McLink failed: ret = -1
[04-16 15:19:42.133] CamHAL[ERR] set up mediaCtl failed
[04-16 15:19:42.133] CamHAL[ERR] @configure Device Configure failed
[04-16 15:19:42.133] CamHAL[ERR] failed to config streams.
ERROR: from element /GstPipeline:pipeline0/Gstcamerasrc:camerasrc0: src pad: Internal data flow error.
Additional debug info:
gstcambasesrc.cpp(3143): gst_cam_base_src_loop (): /GstPipeline:pipeline0/Gstcamerasrc:camerasrc0:
streaming task paused, reason not-negotiated (-4)
Execution ended after 0:00:00.004819429
Setting pipeline to NULL ...
Freeing pipeline ...
on X1 Carbon Gen 11 21HMCTO1WW with an ov2740 sensor. Any clues on what
might be wrong? I tried wiping out my archlinux-ipu6-webcam folder,
running ./uninstall.sh, ./install.sh, reboot.
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJXLII7CH3ZMANBFCKNQV3Y5UXXBAVCNFSM6AAAAABGGJPEM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGIYTMOJRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Still not working I'm afraid, in fact when I did that I went back to getting this in the which I had previously seen prior to a reboot before I had tried |
|
Could be Manjaro specific issue |
|
@lukemarsden I got your exact same error while I was in the process of troubleshooting, but before I realized I should document my work for others and I don't remember what fixed it. So I don't think it's a Manjaro issue, like @elhossary suggested. Are you doing a fresh install or trying to upgrade? |
|
It was an upgrade from the main version that failed. I also tried running
uninstall.sh. Should I try reinstalling the whole OS?
lukemarsden.net
***@***.***
@lmarsden <https://twitter.com/lmarsden>
…On Thu, 18 Apr 2024 at 02:40, Daniel Sato ***@***.***> wrote:
@lukemarsden <https://github.com/lukemarsden> I got your exact same error
while I was in the process of troubleshooting, but before I realized I
should document my work for others and I don't remember what fixed it. So I
don't think it's a Manjaro issue, like @elhossary
<https://github.com/elhossary> suggested.
Are you doing a fresh install or trying to upgrade?
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACATUR6CDPZRUNBKBFIWFTY54QA7AVCNFSM6AAAAABGGJPEM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSHAZTSMJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hey guys, thanks for the effort (for the PR and testing). Tested on kernel
|
|
Trying to install on XPS-13 9315 Linux 6.6.27-1-lts.
|
|
reboot is needed after running uninstall.sh, then run install.sh on LTS kernel |
Getting the same error. |
|
Can confirm it not working with 6.8.7-arch1-1 on XPS 9320. (fresh install) |
|
@mar565 I wouldn't expect it to; I'm sorry if the notes were unclear. The upstream Intel repos have added commits that are intended to support 6.7 and 6.8 kernels; however they break compatibility with the 6.6 LTS kernels that were working before (see the main branch readme). If you're interested in trying to build these packages for the 6.8 kernel, you'll need to un-pin |
|
I tested the main branch and this PR on the latest kernel (fresh install), and it did not work. |
|
@elhossary to be clear, it's expected that this branch will only work on the LTS kernel; it explicitly pulls commits that exclude the work that's been done upstream to support 6.7+. That work seemed to break support on the LTS kernel.
Is this the |
|
as I remember, yes |
|
I was able to make a more current version of If you want to try it, you could unpin those commits and modify the source. If you build modified source with |
|
I changed to the LTS kernel and re-installed it with in between reboots. Now it seems that I messed something up. On boot it tells me it cant find the files for the device: dmesg: |
|
@mar565 that's a new one for me. Maybe try rebuilding and reinstalling |
|
Got it working. Thank you! |
|
I'm not sure honestly; I haven't tried a mainline kernel. Thinking about digging in though; it seems like somebody should. Won't have time this week though. |
|
It work on the 6.6.28-1-lts kernel with an existing config. I had to use the uninstall script, reboot, then using the install script. I am on wayland so I did this fix #71 .
|
|
Can confirm that this is working on 6.6 kernel, Manjaro with #71 Thanks! |
|
I've been running this for a few days and noticed that I've added intel/ipu6-camera-hal#96 as a patch to fix this. |
|
@twouters can you share an updated PKGBUILD that includes that patch? |
|
|
I'm new to working with PKGBUILDs, but is it a normal practice to copy the patch for the whole commit? I feel like a |
I've seen such approach with patches fairly often (nothing wrong with it, you just have the patch file alongside PKGBUILD). Sometimes you can't cherry pick because the commit does not exist ;) |
|
I believe we should focus on LTS kernels only for this PR or the main repo. |
This is fantastic news @elhossary. Phoronix is such a lynchpin for the desktop Linux community. |
|
@elhossary This is really great news. Thanks for the hint! With this being said, I'll merge this PR now. |
