Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for cookie jar #35

Merged
merged 4 commits into from
May 26, 2019
Merged

Conversation

stefanoj3
Copy link
Owner

@stefanoj3 stefanoj3 commented May 26, 2019

Adds support for part of the requirements of #32

@codecov
Copy link

codecov bot commented May 26, 2019

Codecov Report

Merging #35 into master will increase coverage by 0.83%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   85.68%   86.51%   +0.83%     
==========================================
  Files          16       16              
  Lines         482      497      +15     
==========================================
+ Hits          413      430      +17     
+ Misses         36       35       -1     
+ Partials       33       32       -1
Impacted Files Coverage Δ
pkg/cmd/scan.go 85.71% <100%> (+1.29%) ⬆️
pkg/cmd/config.go 46.15% <33.33%> (-1.68%) ⬇️
pkg/scan/bootstrap.go 83.67% <60%> (-2.7%) ⬇️
pkg/cmd/generate_dictionary.go 80% <0%> (+12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef00d9...05302d2. Read the comment docs.

@stefanoj3 stefanoj3 merged commit 5ef32b6 into master May 26, 2019
@stefanoj3 stefanoj3 deleted the adding_support_for_cookie_jar branch May 26, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant