Add common virtualenv locations to flake8 exclude and .gitignore #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add .env/ .venv/ and venv/ to flake8 extend-exclude in setup.cfg
- Add common in-tree locations for virtualenv environments to .gitignore (.env, .venv/, venv/) - .env is also commonly used to store potentially confidential information such as API keys, so should probably be in here as a matter-of-course safety measure anyway, even though this project doesn't use such files.
francoisfreitag
force-pushed
the
flake8_excludes
branch
from
a5d3ec7 to
f7a4042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor quality of life improvement for (potential) contributors, this stops flake8 generating a barrage of errors when run, if you have a virtualenv in one of the common in-tree locations (.venv/, venv/ .env/).
Adds these paths to both flake8 extend-ignore in setup.cfg and .gitignore
Fixes #546