Fix block size corner case on generation #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandeberg
force-pushed
the
2632-block-generation-size
branch
from
1c79222 to
ee343ee
Compare
|
This should fix the problem. Approved. |
theoreticalbts
approved these changes
Jul 13, 2018
lukestokes
reviewed
Jul 13, 2018
libraries/chain/database.cpp
Outdated
|
|
||
| signed_block pending_block; | ||
| idump( (total_block_size) ); |
There was a problem hiding this comment.
Is this a debugging statement? Sorry for the newbie question, I couldn't find much about what "idump" does and was curious.
There was a problem hiding this comment.
Yes, I thought I had removed them. idump is info level, dump object. There is also ilog for log at info level. And ddump, wdump, and edump for debug, warning, and error and their corresponding logs as well.
mvandeberg
force-pushed
the
2632-block-generation-size
branch
from
ee343ee to
be028e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2632