Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro style (width) changed after loading plugin #22

Closed
bGZo opened this issue May 9, 2023 · 2 comments
Closed

Macro style (width) changed after loading plugin #22

bGZo opened this issue May 9, 2023 · 2 comments
Labels

Comments

@bGZo
Copy link

bGZo commented May 9, 2023

Thanks for your awesome job, it really helps me a lot in inserting template. Today I try to use the macro function and found the style(width) of {{iframe }} is not consist, whose commands I used is same as #1.

:macros {
 "iframe" "<iframe src='$1' style='height:320px'></iframe>"
}

And here is the means to reproduce:

Logseq_462

I found that the plugin is not including the css code, and I have no idea how to avoid rendering this block. So I try to use another alternative solution as follows:

<iframe src = '' style= 'height:320px'></iframe>
template:: iframe-full-house

It works as well. Thus the priority of issue is not much high. I'm looking forward to fix it one day. Thanks your job again.

(Windows 11; logseq@0.9.4; losgeq13-full-house-plugin@2.6.0)

@stdword
Copy link
Owner

stdword commented May 9, 2023

Hello! Thank you for the kind words about my work 🙏❤️

And thank you for pointing out the issue, I guess I forgot to remove the CSS I added to the plugin while experimenting with macros. It loads dynamically, without a separate CSS file.

The CSS was added to fight this bug. However, since the plugin doesn't use macros and I made an appropriate PR to Logseq itself, I removed the CSS.

Regarding the priority and workaround you found, I haven't released the plugin yet. The fix will come with the next release, along with other features, to avoid bothering users with such a low-priority fix.

BTW: There's also another way to keep the iframe wide. By adding custom CSS for your macro name:

div.macro[data-macro-name=iframe] {
    display: block;
}

@stdword stdword closed this as completed in dbf38c1 May 9, 2023
github-actions bot pushed a commit that referenced this issue Aug 14, 2023
# [3.0.0](v2.6.0...v3.0.0) (2023-08-14)

### Bug Fixes

* do not replace text if rendered template is empty ([8486445](8486445))
* **engine:** <% current page %> stands for current page, not for `c.page` ([af8156a](af8156a))
* **engine:** add fool-protection for inline templates to prevent tags intersection ([b64136f](b64136f))
* **engine:** handling quotes in protections code ([55a6af9](55a6af9))
* **engine:** qoutes handling in corner cases ([6ca7be5](6ca7be5))
* **engine:** trimming right whitespaces overriding ([6e975cc](6e975cc))
* fix link to docs in notification about :macros usage ([7003a07](7003a07))
* propper c.template.name in case of accessing template by property name ([5738a47](5738a47))
* propper render of `c.identity` ([1bfb522](1bfb522))
* remove css rule for macros ([dbf38c1](dbf38c1)), closes [#22](#22)
* rendering `c.args` ([fbb3755](fbb3755))
* **rendering:** "template not found" when template is a first block of a page ([e022a56](e022a56))
* **rendering:** prevent recursive rendering ([41458e1](41458e1))
* **tags:** `empty` template tag null value should be fallen back ([a2a225c](a2a225c))
* **tags:** return null for `empty` template tag ([5c707a4](5c707a4))

### Features

* add isoWeek plugin for dayjs ([18196bf](18196bf))
* **args:** positional only args with syntax `c.args.$1` ([52f7caf](52f7caf))
* **command:** command to convert template to a new syntax ([daf7ea9](daf7ea9))
* **context:** added `page.namespace` ([73ba0bd](73ba0bd))
* **engine:** autodetecting of syntax style ([ef6d611](ef6d611))
* **engine:** render basic standard templates syntax ([d61cb53](d61cb53))
* **engine:** render standard templates syntax with nlp ([53d619d](53d619d))
* **engine:** support new syntax for rendering tags ([ad75616](ad75616))
* **notifications:** add notification about new syntax; notify only old users ([c900fa4](c900fa4))
* provide delayed option for views ([3c1bb84](3c1bb84))
* **tags:** `date.nlp` template tag ([eef9e01](eef9e01))

### BREAKING CHANGES

* **engine:** before: ``{ x }``, after: ``x``
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants