Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmean #4395

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmean #4395

wants to merge 18 commits into from

Conversation

Neerajpathak07
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsnanmean
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Neerajpathak07 Neerajpathak07 marked this pull request as draft December 30, 2024 19:12
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Dec 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsnanmean $\color{green}345/345$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}345/345$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 30, 2024 19:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 30, 2024
kgryte
kgryte requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments. Please do a very thorough review of all your open PRs implementing similar changes. They are currently inundated with copy-paste mistakes.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07
Copy link
Contributor Author

@kgryte Thank you for you review. Extremely sorry for the errors. I'll fix these mistakes for other PR's as well.

@Neerajpathak07
Copy link
Contributor Author

@kgryte
I have made all the essential changes to all the packages requiring similar implementations.
This time I was able to understand what the package was demanding for and how to go about it.

@Neerajpathak07
Copy link
Contributor Author

@kgryte I have made the suggested changes throughout all my other PR's would really appreciate a review

@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 12, 2025 15:15
@Neerajpathak07
chore: minor clean up
942fb6b
@Neerajpathak07
chore: update addon
7056bcd
@Neerajpathak07
Merge branch 'develop' into ndarray-dsnanmean
c143b3d 
Signed-off-by: Neeraj Pathak <neerajrpathak710@gmail.com>
@Neerajpathak07
chore: clean up
1a258ab 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@Neerajpathak07
chore: max-len
a20dfba
@Neerajpathak07
chore: max-len
db0cfa9
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 10, 2025 15:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 10, 2025
aayush0325
aayush0325 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be clear of any errors now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@aayush0325 aayush0325 aayush0325 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neerajpathak07 @stdlib-bot @kgryte @aayush0325