Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/ext/base/dapxsumkbn-wasm #3204

Merged
merged 7 commits into from
Nov 22, 2024
Merged

feat: add blas/ext/base/dapxsumkbn-wasm #3204

merged 7 commits into from
Nov 22, 2024

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds the package blas/ext/base/dapxsumkbn-wasm

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
feat: add wasm support for blas/ext/base/dapxsumkbn
70ee599 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 20, 2024
@Snehil-Shah Snehil-Shah added the WebAssembly Issue involves or relates to WebAssembly. label Nov 20, 2024
headlessNode
headlessNode reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@headlessNode headlessNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Snehil-Shah docs related suggestions since we wanna keep consistent terminologies across packages.

lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn-wasm/docs/repl.txt Outdated Show resolved Hide resolved
@Snehil-Shah
docs: keep it consistent
b9d84aa 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

@kgryte kgryte changed the title feat: add wasm support for blas/ext/base/dapxsumkbn feat: add blas/ext/base/dapxsumkbn-wasm Nov 21, 2024
@Snehil-Shah
refactor: update binary according to stdlib-js@f4009fd
7d7b456 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah Snehil-Shah requested a review from kgryte November 21, 2024 09:53
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dapxsumkbn-wasm $\color{green}562/562$
$\color{green}+100.00\%$ 		$\color{green}17/17$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}562/562$
$\color{green}+100.00\%$
blas/ext/base/dapxsumkbn $\color{green}392/392$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}392/392$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

For reference, the downstream test failures are expected. @headlessNode is currently working on a patch.

Looks like the test failures have now been addressed. Will do a review later today. Thanks for working on this, @Snehil-Shah!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 21, 2024
@kgryte
Copy link
Member

kgryte commented Nov 21, 2024

/stdlib merge

kgryte
kgryte approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 22, 2024
@kgryte kgryte merged commit f1fa458 into stdlib-js:develop Nov 22, 2024
12 checks passed
@Snehil-Shah Snehil-Shah deleted the dapxsumkbn-wasm branch November 23, 2024 18:45
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
@Snehil-Shah @kgryte
@stdlib-bot @pranav-1720
feat: add blas/ext/base/dapxsumkbn-wasm
e18b1df 
PR-URL: stdlib-js#3204
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Muhammad Haris <harriskhan047@outlook.com>
Reviewed-by: Aman Bhansali <bhansali.1@iitj.ac.in>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Dec 4, 2024
@Snehil-Shah @kgryte
@stdlib-bot @Neerajpathak07
feat: add blas/ext/base/dapxsumkbn-wasm
73aef4a 
PR-URL: stdlib-js#3204
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Muhammad Haris <harriskhan047@outlook.com>
Reviewed-by: Aman Bhansali <bhansali.1@iitj.ac.in>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhraghuvanshii saurabhraghuvanshii saurabhraghuvanshii left review comments

@kgryte kgryte kgryte approved these changes

@headlessNode headlessNode Awaiting requested review from headlessNode

@aman-095 aman-095 Awaiting requested review from aman-095

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Snehil-Shah @kgryte @stdlib-bot @aman-095 @headlessNode @saurabhraghuvanshii