Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor JavaScript implementation and add C ndarray implementation for blas/base/sasum #2926

Merged
merged 3 commits into from
Sep 21, 2024
Merged

feat: refactor JavaScript implementation and add C ndarray implementation for blas/base/sasum #2926

merged 3 commits into from
Sep 21, 2024

Conversation

aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • updates existing Js implementation based on the latest lapack implementation.
  • add C ndarray API.
  • update documentation.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 20, 2024
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Sep 20, 2024
@aman-095 aman-095 marked this pull request as ready for review September 20, 2024 13:45
@kgryte
Apply suggestions from code review
6cec887 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the JS ndarray implementation, this PR looks good to go. Once the implementation is updated, should be ready for merge.

@kgryte kgryte changed the title feat: update Js implementation and add C ndarray implementation for blas/base/sasum feat: refactor JavaScript implementation and add C ndarray implementation for blas/base/sasum Sep 21, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Sep 21, 2024
kgryte
kgryte approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 21, 2024
@kgryte kgryte merged commit d93e862 into stdlib-js:develop Sep 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot