Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/drot #1823

Merged
merged 27 commits into from
Apr 19, 2024
Merged

feat: add blas/base/drot #1823

merged 27 commits into from
Apr 19, 2024

Conversation

aman-095
Copy link
Member

Resolves #276.

Description

This RFC proposes to add a routine to apply a plane rotation as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/drot is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aman-095
Copy link
Member Author

@kgryte @Pranavchiku @Planeshifter please review I have applied the necessary changes.

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 12, 2024
@Pranavchiku Pranavchiku changed the title feat: add BLAS Level 1 drot routine feat: add blas/base/drot Mar 12, 2024
Pranavchiku
Pranavchiku suggested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Nice work. Requested changes, once done this will be ready to merge.

lib/node_modules/@stdlib/blas/base/drot/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/lib/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/lib/index.js Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/test/test.drot.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/test/test.drot.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/base/drot/test/test.ndarray.js Outdated Show resolved Hide resolved
Pranavchiku
Pranavchiku suggested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Nice work. Requested changes, once done this will be ready to merge.

@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 12, 2024
@aman-095
Copy link
Member Author

CC @kgryte @Pranavchiku

@kgryte
Apply suggestions from code review
25d7542 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
18681d4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-095 Thanks for continuing to work on this. Left a number of comments regarding documentation which still need to be addressed.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2024
@aman-095 aman-095 mentioned this pull request Apr 1, 2024
Closed
6 tasks
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 19, 2024
kgryte
kgryte reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte
Copy link
Member

kgryte commented Apr 19, 2024

@aman-095 Note that I did a fairly heavy refactor of the tests and other changes. You'll want to apply similar changes to your srot PR.

@kgryte kgryte merged commit 3f1caa3 into stdlib-js:develop Apr 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: add BLAS Level 1 drot routine
4 participants
@aman-095 @kgryte @Pranavchiku @Planeshifter