-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9470] ignore dark mode on iOS #9564
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (6)
|
I don't see a difference, Status Bar is still using the white appearance, making it invisible. Keyboards are using the dark appearance, image picker remains all bugged up 😿 |
@errorists the issue with amount on transaction sending is fixed, but it seems that the stuff which is outside application's view is not affected by this change |
@rasom can you go a layer upward, more global, more root? ;) |
it seems that we need to upgrade RN in order to fix status bar facebook/react-native#26619 (comment) |
keyboard should be fixed now, not sure if we can fix image picker |
2623023
to
64089b4
Compare
I read a bit more about @errorists please take a look when build will be ready. Keyboard, image picker, transaction amount are fixed, status bar is not. We still need to upgrade RN for status bar, I will try to do this tomorrow. |
64089b4
to
38e621e
Compare
Status bar still has to be fixed
I will merge this one and upgrade RN in a separate PR, it might take some time. |
38e621e
to
cd04862
Compare
fixes (partially) #9470