Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9470] ignore dark mode on iOS #9564

Merged
merged 1 commit into from
Dec 2, 2019
Merged

[#9470] ignore dark mode on iOS #9564

merged 1 commit into from
Dec 2, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Dec 2, 2019

fixes (partially) #9470

@rasom rasom requested a review from a team as a code owner December 2, 2019 12:23
@auto-assign auto-assign bot removed the request for review from a team December 2, 2019 12:23
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rasom rasom self-assigned this Dec 2, 2019
ios/StatusIm/AppDelegate.m Outdated Show resolved Hide resolved
@status-im-auto
Copy link
Member

status-im-auto commented Dec 2, 2019

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eecf848 #1 2019-12-02 12:31:57 ~8 min ios 📦ipa 📲
✔️ eecf848 #1 2019-12-02 12:38:05 ~14 min android-e2e 📦apk 📲
✔️ eecf848 #1 2019-12-02 12:38:23 ~15 min android 📦apk 📲
✔️ 2623023 #2 2019-12-02 15:18:39 ~8 min ios 📦ipa 📲
✔️ 2623023 #2 2019-12-02 15:21:18 ~11 min android-e2e 📦apk 📲
✔️ 2623023 #2 2019-12-02 15:26:41 ~16 min android 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 64089b4 #3 2019-12-02 15:42:06 ~10 min ios 📦ipa 📲
✔️ 64089b4 #3 2019-12-02 15:44:52 ~13 min android-e2e 📦apk 📲
✔️ 64089b4 #3 2019-12-02 15:49:15 ~17 min android 📦apk 📲
✔️ cd04862 #5 2019-12-02 17:28:41 ~8 min ios 📦ipa 📲
✔️ cd04862 #5 2019-12-02 17:32:16 ~11 min android 📦apk 📲
✔️ cd04862 #5 2019-12-02 17:32:21 ~12 min android-e2e 📦apk 📲

@errorists
Copy link
Contributor

I don't see a difference, Status Bar is still using the white appearance, making it invisible. Keyboards are using the dark appearance, image picker remains all bugged up 😿

@rasom
Copy link
Contributor Author

rasom commented Dec 2, 2019

@errorists the issue with amount on transaction sending is fixed, but it seems that the stuff which is outside application's view is not affected by this change

@errorists
Copy link
Contributor

@rasom can you go a layer upward, more global, more root? ;)

@rasom
Copy link
Contributor Author

rasom commented Dec 2, 2019

it seems that we need to upgrade RN in order to fix status bar facebook/react-native#26619 (comment)

@rasom rasom requested a review from a team December 2, 2019 15:09
@rasom
Copy link
Contributor Author

rasom commented Dec 2, 2019

keyboard should be fixed now, not sure if we can fix image picker

@rasom
Copy link
Contributor Author

rasom commented Dec 2, 2019

I read a bit more about UIUserInterfaceStyle and seems that it is a problem only in case if app is built using Xcode 10.*, it should work in our case.

@errorists please take a look when build will be ready. Keyboard, image picker, transaction amount are fixed, status bar is not. We still need to upgrade RN for status bar, I will try to do this tomorrow.

Status bar still has to be fixed
@rasom
Copy link
Contributor Author

rasom commented Dec 2, 2019

I will merge this one and upgrade RN in a separate PR, it might take some time.

@rasom rasom merged commit cd04862 into develop Dec 2, 2019
@rasom rasom deleted the ignor-dark-mode-ios#9470 branch December 2, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants