Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary fix for realm issues #8367

Closed
wants to merge 1 commit into from
Closed

temporary fix for realm issues #8367

wants to merge 1 commit into from

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Jun 5, 2019 •
edited by StatusWrike
Loading

Dropping 64bit platforms as a temporary workaround for Realm.js issues in #8366.

We will have to undo-this using #8326 once Realm.js issue is fixed.

See for context:

@jakubgs
temporary for for realm issues
04c0c68 
See:
* #8366
* realm/realm-js#2282
* facebook/react-native#25060

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs added the android label Jun 5, 2019
@jakubgs jakubgs requested review from mandrigin, yenda and rasom June 5, 2019 15:05
@jakubgs jakubgs requested a review from a team as a code owner June 5, 2019 15:05
@jakubgs jakubgs self-assigned this Jun 5, 2019
@ghost
Copy link

ghost commented Jun 5, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@jakubgs jakubgs mentioned this pull request Jun 5, 2019
Closed
@jakubgs jakubgs changed the title temporary for for realm issues temporary fix for for realm issues Jun 5, 2019
@jakubgs jakubgs changed the title temporary fix for for realm issues temporary fix for realm issues Jun 5, 2019
@yenda
Copy link
Contributor

yenda commented Jun 5, 2019

Realm makes the bug more obvious but it seems these crashes happen a lot on 64 bits capable devices and are caused by RN, we'll have to follow up on facebook/react-native#24261

@status-im-auto
Copy link
Member

status-im-auto commented Jun 5, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 04c0c68 #1 2019-06-05 15:19:52 ~14 min ios 📦 ipa
✔️ 04c0c68 #1 2019-06-05 15:20:46 ~15 min android-e2e 📦 apk
✔️ 04c0c68 #1 2019-06-05 15:20:46 ~15 min linux 📦 App
✔️ 04c0c68 #1 2019-06-05 15:22:03 ~16 min windows 📦 exe
✔️ 04c0c68 #1 2019-06-05 15:23:00 ~17 min macos 📦 dmg
✔️ 04c0c68 #1 2019-06-05 15:23:25 ~17 min android 📦 apk

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_logcat_send_transaction_in_1_1_chat
Device sessions

23. test_request_and_receive_eth_in_1_1_chat
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_send_tokens_in_1_1_chat
Device sessions

30. test_network_mismatch_for_send_request_commands
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@annadanchenko
Copy link

@jakubgs @yenda first launch of the app was fine but if close it and try to launch again then unfortunately, Status can't be launched and popup "Status PR has stopped" is shown.

Steps:

  1. Install app
  2. Launch app. Do not create any account
  3. kill app
  4. Launch app again

full logcat:
reproduce.txt

@yenda
Copy link
Contributor

yenda commented Jun 6, 2019

@jakubgs can you confirm that this is the only place where 64bits stuff has to be excluded?

@yenda yenda mentioned this pull request Jun 6, 2019
Closed
@jakubgs
Copy link
Member Author

jakubgs commented Jun 6, 2019

Yes.

@jakubgs
Copy link
Member Author

jakubgs commented Jun 6, 2019

I've tested this on my OnePlus 6 with a Snapdragon 845 which a 64 bit cpu and it works fine. I tested as @annadanchenko did, with closing it and re-opening and everything worked fine.

But then again I installed the nightly and it works just fine, so maybe this isn't just 64 bit specific, maybe it's CPU specific.

@krisc
Copy link

krisc commented Jun 6, 2019

This did not work for me. Using Samsung S6 Edge, Android 7.

@jakubgs
Copy link
Member Author

jakubgs commented Jun 6, 2019

Thanks for the info, try #8368.

@yenda
Copy link
Contributor

yenda commented Jun 7, 2019

Closing because #8368 is a better fix

@yenda yenda closed this Jun 7, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
@jakubgs jakubgs deleted the temp-realm-fix-drop-64bit branch May 12, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@mandrigin mandrigin Awaiting requested review from mandrigin

@rasom rasom Awaiting requested review from rasom

Assignees
No one assigned
Labels
android Tested - Issues
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jakubgs @yenda @status-im-auto @statustestbot @annadanchenko @krisc @flexsurfer