-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes activities list cleaning after unsuccessful activites request from status-go #22270
base: release/2.33.x
Are you sure you want to change the base?
Conversation
Jenkins Builds
|
@vkjr thanks a lot for the fix! Currently, activity history is not cleared, so this part of the issue is fixed. Although, after performing DAI bridge transaction, all the subsequent transactions (even successful ones) still not appearing in activity history. Just want to make sure, do I understand correctly that this particular part of the issue is going to be fixed in the upcoming satus go fix? Steps:
Actual result: transaction does not appear in Activity history telegram-cloud-document-2-5366074879118437208.mp4 |
@pavloburykh, yes, due to the issue in |
87% of end-end tests have passed
Failed tests (6)Click to expandClass TestFallbackMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMergedThree:
Expected to fail tests (3)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletCollectibles:
Passed tests (59)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestAndroid13:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestAndroid12:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestWalletCollectibles:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
@vkjr Thank you for PR. No issues from my side. PR is ready to be merged Tested bridge transactions with different kinds of navigation networks and assets: Navigation Paths to Bridge Option:✅ Open wallet main page → Long-tap the asset → Tap "Bridge" option Routes for confirmed transactions:✅ L1 → L2 Optimism (ETH) Also confirmed 1 tx for collectibles, swap, send flow |
33% of end-end tests have passed
Not executed tests (3)Failed tests (2)Click to expandClass TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
Summary
This is a mobile-side part of the #22265
After bridging L1->L2 retrieving of activities fails in
status-go
. Whilestatus-go
will have own fix, there is also a problem on mobile side - we do not check the error code that activities request returned. As a result we are clearing existing activities but we do not have an updated list.Review notes
Now we check error code and do not clean old data if there is no new.
Testing notes
This is mobile-only fix. When
status-go
fix merged we can bump the status-go version in this PR and merge all it once in release branch.Platforms
Areas that may be impacted
Functional
Steps to test
status: ready