Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: move android logs from download dir to private app data folder #22268

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Mar 10, 2025

With this PR, all log files in Android will be stored in private app data folder for new Status account.

relate comment

Testing notes

Pls check log files are there when send log via email.
Old log files won't be included anymore when send log.

Platforms

  • Android

Steps to test

  • Open Status
  • Shake device
  • Report a bug
  • Submit by email with logs archive

status: ready

@qfrank qfrank self-assigned this Mar 10, 2025
@qfrank qfrank force-pushed the frank/chore/move_android_log branch from 8a78f7a to 93b9c84 Compare March 10, 2025 08:39
@status-im-auto
Copy link
Member

status-im-auto commented Mar 10, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 93b9c84 #2 2025-03-10 08:44:32 ~4 min tests 📄log
✔️ 93b9c84 #2 2025-03-10 08:47:02 ~7 min android-e2e 🤖apk 📲
✔️ 93b9c84 #2 2025-03-10 08:48:18 ~8 min android 🤖apk 📲
✔️ 93b9c84 #2 2025-03-10 08:58:00 ~17 min ios 📱ipa 📲

@qfrank qfrank requested a review from ilmotta March 10, 2025 11:33
@qfrank qfrank marked this pull request as ready for review March 10, 2025 11:34
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qfrank Works well in my simple test 🚀

My only concern is what @pavloburykh shared:

When we shake an Android device, we can send an error report with logs via email. However, sometimes, especially during release testing, the log file becomes too large to be delivered via email.

-- https://discord.com/channels/1210237582470807632/1347177230874181692/1347460951934373940

Wouldn't merging this PR cause a disruption in QA if we don't provide a way to at least save the logs in the local file system or share directly via other apps?

@qfrank
Copy link
Contributor Author

qfrank commented Mar 11, 2025

Wouldn't merging this PR cause a disruption in QA if we don't provide a way to at least save the logs in the local file system or share directly via other apps?

I created a feature issue to track, once we solve the feature issue, we can merge this one, WDYT? @ilmotta

@ilmotta
Copy link
Contributor

ilmotta commented Mar 11, 2025

Wouldn't merging this PR cause a disruption in QA if we don't provide a way to at least save the logs in the local file system or share directly via other apps?

I created a feature issue to track, once we solve the feature issue, we can merge this one, WDYT? @ilmotta

Sounds perfect by me @qfrank. Thanks for the initiative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

3 participants