fix_: messages are not delivered if the sender's device time is set manually #22178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
Parveshdhull
approved these changes
Feb 24, 2025
95% of end-end tests have passedFailed tests (2)Click to expandClass TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (62)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestAndroid13:
Class TestFallbackMultipleDevice:
Class TestWalletCollectibles:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestAndroid12:
Class TestCommunityMultipleDeviceMergedTwo:
|
|
@qfrank Thank you for your fixes! Please confirm whether this is the expected behavior or an issue:
Actual results:
|
|
@qfrank I believe this is already an issue: ISSUE 1: The sender with manually set time does not receive messages from the reciever Step:
Actual results:
Expected results: |
|
@qfrank I reported it as separately issue, please look too: ISSUE 2: Messages are not received by either side after resetting the time back to the correct value
Actual results:
Expected results: |
qfrank
force-pushed
the
fix/wrong_device_time
branch
from
98add8d to
8fdcd37
Compare
ilmotta
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Approving the PR in mobile. @Horupa-Olena @qfrank please check out my comment here status-im/status-go#6358 (review), I'm looking forward to hear your thoughts.
qfrank
force-pushed
the
fix/wrong_device_time
branch
2 times, most recently
from
1538e8a to
352e051
Compare
|
Hi @Horupa-Olena , thanks for the feedback, could you re-check if latest update solved all the issues you mentioned? pls use new profile and disable light client mode when testing, thanks! Because I found light client is not that reliable when I was testing before. Also pls wait some time(e.g. 1-2min) when trying to receive the message that reach instantly. If you still found issues, pls share logs with me if it's avaiable :) |
|
@qfrank Thank you for fix and advices for testing! |
qfrank
force-pushed
the
fix/wrong_device_time
branch
2 times, most recently
from
9be61f5 to
98d512d
Compare
done ✅ @Horupa-Olena |
|
@qfrank Sorry for the long wait! Results: Issue 1 and Issue 2 – fixed! I retested the PR on two devices:
The following scenarios were checked:
|
User B have real time in activity center an 1-1 chat.
This issue is constant. On User A's side, in chat, the real time is always displayed instead of the changed time. |
|
@qfrank And found also similar behaviour to this case:
Actual results:
|
|
emm.. let me reply your last 2 comments, I think it's normal, what my fix done is: whatever you changed your device time, the time in app is separated from device time, the time in app will keep the same as NTP service(the real time). @Horupa-Olena cc @ilmotta |
@qfrank Okay, I understand. Thank you! So from the QA side, the PR can be merged. |
qfrank
force-pushed
the
fix/wrong_device_time
branch
from
98d512d to
58d454c
Compare
76% of end-end tests have passedFailed tests (12)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Expected to fail tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletCollectibles:
Passed tests (52)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestAndroid12:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestFallbackMultipleDevice:
Class TestAndroid13:
Class TestCommunityMultipleDeviceMergedThree:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate status-go PR
Testing notes
Platforms
Areas that may be impacted
Functional
Steps to test
Pls check reproduce steps as reference
status: ready