-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): Allow test-watch-for-repl target to run while the app is running #20827
Merged
ilmotta
merged 1 commit into
develop
from
ilmotta/allow-watch-repl-target-to-run-alongside-mobile-build
Jul 24, 2024
Merged
chore(tests): Allow test-watch-for-repl target to run while the app is running #20827
ilmotta
merged 1 commit into
develop
from
ilmotta/allow-watch-repl-target-to-run-alongside-mobile-build
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
shivekkhurana
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this feature.
This was making me brain hurt for sometime. Whenever I wanted to test, I lost my REPL connection.
J-Son89
approved these changes
Jul 21, 2024
d96fa11
to
e605765
Compare
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
e605765
to
8928ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a long standing problem, at least in my machines: I can't run in parallel the make target![:rage2: :rage2:](https://assets.fantasygmm.top/images/icons/emoji/rage2.png)
run-clojure
andtest-watch-for-repl
, or in other words, I can't do run tests via the REPL while the app is runningDetails
I found out that shadow-cljs fails to build because it does not expand the environment variables
SHADOW_OUTPUT_TO
andSHADOW_NS_REGEXP
if and only if therun-clojure
target was executed. Clearly looks like a bug.This is the top of the stacktrace, and it happens because it doesn't know where to output the test build because the env var wasn't expanded:
The solution is to pass the option
--config-merge
to shadow-cljs and override both:ns-regexp
and:output-to
because CLI args override options from env vars in shadow-cljs.Areas that may be impacted
None.
Steps to test
Please, check you can do
make run-clojure
in one session/terminal andmake test-watch-for-repl
in another session/terminal, and that you are able to connect with the REPL successfully.If you are using Emacs and you are already connected to the normal app REPL (
:mobile
target), after runningtest-watch-for-repl
you can connect to the test REPL by usingcider-connect-sibling-cljs
. There are probably other ways. Then, if you have selected the correct CLJS buffer, if you run the tests with something like(cljs.test/run-tests)
it will work, as usual. I don't know the instructions to connect to two REPLs in VS Code, but I'm pretty sure this is supported.status: ready