Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dApps tab from Wallet #20818

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Remove dApps tab from Wallet #20818

merged 5 commits into from
Jul 23, 2024

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Jul 19, 2024

fixes #20793

Platforms

  • Android
  • iOS

status: ready

@alwx alwx self-assigned this Jul 19, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jul 19, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a95062c #1 2024-07-19 09:55:08 ~4 min tests 📄log
✔️ a95062c #1 2024-07-19 09:58:10 ~7 min android-e2e 🤖apk 📲
✔️ a95062c #1 2024-07-19 09:58:10 ~7 min android 🤖apk 📲
✔️ a95062c #1 2024-07-19 10:01:51 ~11 min ios 📱ipa 📲
5754f4f #2 2024-07-22 07:16:12 ~3 min tests 📄log
✔️ 5754f4f #2 2024-07-22 07:19:34 ~7 min android-e2e 🤖apk 📲
✔️ 5754f4f #2 2024-07-22 07:19:38 ~7 min android 🤖apk 📲
✔️ 5754f4f #2 2024-07-22 07:21:45 ~9 min ios 📱ipa 📲
✔️ de709d4 #3 2024-07-22 13:15:22 ~5 min tests 📄log
✔️ de709d4 #3 2024-07-22 13:18:29 ~8 min android-e2e 🤖apk 📲
✔️ de709d4 #3 2024-07-22 13:18:33 ~8 min android 🤖apk 📲
✔️ de709d4 #3 2024-07-22 13:19:38 ~9 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 714944d #4 2024-07-23 07:24:44 ~4 min tests 📄log
✔️ 714944d #4 2024-07-23 07:26:54 ~6 min android 🤖apk 📲
✔️ 714944d #4 2024-07-23 07:27:20 ~7 min android-e2e 🤖apk 📲
✔️ 714944d #4 2024-07-23 07:29:54 ~9 min ios 📱ipa 📲
✔️ 4ff832c #5 2024-07-23 15:37:36 ~4 min tests 📄log
✔️ 4ff832c #5 2024-07-23 15:39:59 ~6 min android 🤖apk 📲
✔️ 4ff832c #5 2024-07-23 15:40:29 ~7 min android-e2e 🤖apk 📲
✔️ 4ff832c #5 2024-07-23 15:42:10 ~9 min ios 📱ipa 📲

Copy link
Member

@clauxx clauxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@status-im-auto
Copy link
Member

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 1
Passed tests: 5
IDs of failed tests: 727229 
IDs of expected to fail tests: 727232 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.00989 ETH`

    critical/test_wallet.py:156: in test_wallet_send_eth
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4892 but expected to be 0.4893
    



    Expected to fail tests (1)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find EditBox by accessibility id: add-address-to-watch
    Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

    critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
        self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
    ../views/wallet_view.py:163: in add_watch_only_account
        self.account_has_activity_label.wait_for_visibility_of_element()
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element 
    

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (5)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    @qoqobolo qoqobolo self-assigned this Jul 23, 2024
    @qoqobolo
    Copy link
    Contributor

    @alwx no issues so far, but I've got one question:

    Can/should we make the tabs non-scrollable in case the screen is wide enough to fit all the tabs? Is it possible at all, what do you think?
    The device on the video is Pixel 7a

    video_2024-07-23_14-31-36.mp4

    @clauxx
    Copy link
    Member

    clauxx commented Jul 23, 2024

    @alwx no issues so far, but I've got one question:

    Can/should we make the tabs non-scrollable in case the screen is wide enough to fit all the tabs? Is it possible at all, what do you think? The device on the video is Pixel 7a

    video_2024-07-23_14-31-36.mp4

    We could, but unclear how easy it could be. I think it could be a separate issue, but not specific for the dapp-team I guess.

    @qoqobolo
    Copy link
    Contributor

    qoqobolo commented Jul 23, 2024

    @alwx no issues so far, but I've got one question:
    Can/should we make the tabs non-scrollable in case the screen is wide enough to fit all the tabs? Is it possible at all, what do you think? The device on the video is Pixel 7a
    video_2024-07-23_14-31-36.mp4

    We could, but unclear how easy it could be. I think it could be a separate issue, but not specific for the dapp-team I guess.

    I agree, asking here just because it became visible after removing the dapps tab.

    @alwx thanks for the PR, it's ready to be merged.

    @clauxx clauxx merged commit 8597b89 into develop Jul 23, 2024
    6 checks passed
    @clauxx clauxx deleted the bugfix/20793 branch July 23, 2024 15:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: DONE
    Development

    Successfully merging this pull request may close these issues.

    Remove dApps tab from wallet
    7 participants