-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dApps tab from Wallet #20818
Remove dApps tab from Wallet #20818
Conversation
Jenkins BuildsClick to see older builds (12)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
|
@alwx no issues so far, but I've got one question: Can/should we make the tabs non-scrollable in case the screen is wide enough to fit all the tabs? Is it possible at all, what do you think? video_2024-07-23_14-31-36.mp4 |
We could, but unclear how easy it could be. I think it could be a separate issue, but not specific for the dapp-team I guess. |
I agree, asking here just because it became visible after removing the dapps tab. @alwx thanks for the PR, it's ready to be merged. |
fixes #20793
Platforms
status: ready