-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817
Conversation
Jenkins BuildsClick to see older builds (12)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG.
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so we were using the wrong topic. Amazing API design from them as always. Great fix @alwx!
@clauxx yes, there is |
0% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
|
Hey @alwx , thanks for the fixes! I'm finishing work for today, will continue on Monday, but so far I've faced this issue with OpenSea: ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea sideSteps:
Expected result: the wallet is disconnected on OpenSea |
Same situation for https://dydx.trade/ - the wallet is displayed as connected after disconnection on the Status side. It seems this issue is relevant for dapps where a message signature is required when connecting. |
@alwx yep, looks like this. And I suspect there's nothing we can do about it, right? |
@qoqobolo sadly, no. Once we sent the disconnect event, we cannot control the process anymore — we have no connection to the dapp itself and no way of telling them to really disconnect. |
@alwx gotcha. |
…the list of connected dapps
fixes #20797
fixes #20798
Platforms
status: ready