WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817

alwx · 2024-07-19T09:36:56Z

fixes #20797
fixes #20798

Platforms

Android
iOS

status: ready

status-im-auto · 2024-07-19T09:46:03Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`0feb2af`	#2	2024-07-19 09:46:03	~4 min	`tests`	📄`log`
✔️	`0feb2af`	#2	2024-07-19 09:48:38	~7 min	`android`	🤖`apk` 📲
✔️	`0feb2af`	#2	2024-07-19 09:49:03	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`0feb2af`	#2	2024-07-19 09:55:36	~14 min	`ios`	📱`ipa` 📲

✔️	`30126a4`	#3	2024-07-19 11:24:09	~5 min	`tests`	📄`log`
✔️	`30126a4`	#3	2024-07-19 11:27:43	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`30126a4`	#3	2024-07-19 11:27:53	~8 min	`android`	🤖`apk` 📲
✔️	`30126a4`	#3	2024-07-19 11:28:16	~9 min	`ios`	📱`ipa` 📲

✔️	`60df1e4`	#4	2024-07-22 12:38:57	~5 min	`tests`	📄`log`
✔️	`60df1e4`	#4	2024-07-22 12:41:41	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`60df1e4`	#4	2024-07-22 12:42:44	~9 min	`android`	🤖`apk` 📲
✔️	`60df1e4`	#4	2024-07-22 12:44:48	~11 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`62e125e`	#5	2024-07-22 13:07:22	~4 min	`tests`	📄`log`

✔️	`790ed40`	#6	2024-07-22 13:13:27	~5 min	`tests`	📄`log`
✔️	`790ed40`	#6	2024-07-22 13:16:08	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`790ed40`	#6	2024-07-22 13:16:55	~8 min	`android`	🤖`apk` 📲
✔️	`790ed40`	#6	2024-07-22 13:18:37	~10 min	`ios`	📱`ipa` 📲

shivekkhurana

GG.

status-im-auto · 2024-07-19T10:15:11Z

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 727230

IDs of expected to fail tests: 727232

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: `Text` is `0.00679 ETH`

critical/test_wallet.py:184: in test_wallet_send_asset_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.493 but expected to be 0.4931

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find EditBox by accessibility id: add-address-to-watch
Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (5)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

clauxx

ah, so we were using the wrong topic. Amazing API design from them as always. Great fix @alwx!

alwx · 2024-07-19T11:13:34Z

@clauxx yes, there is topic and pairingTopic and even they sometimes confuse them in the docs :D

status-im-auto · 2024-07-19T12:18:06Z

0% of end-end tests have passed

Total executed tests: 1
Failed tests: 1
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 727230

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Tap on found: Button
Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab`

critical/test_wallet.py:163: in test_wallet_send_asset_from_drawer
    self.wallet_2.chats_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

qoqobolo · 2024-07-19T15:14:28Z

Hey @alwx , thanks for the fixes!

I'm finishing work for today, will continue on Monday, but so far I've faced this issue with OpenSea:

ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea side

Steps:

Connect to https://opensea.io/
Press Disconnect in Status

Expected result: the wallet is disconnected on OpenSea
Actual result: the wallet stays connected, you need to log out manually

qoqobolo · 2024-07-22T11:17:00Z

Hey @alwx , thanks for the fixes!

I'm finishing work for today, will continue on Monday, but so far I've faced this issue with OpenSea:

ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea side

Steps:

Connect to https://opensea.io/

Press Disconnect in Status

Expected result: the wallet is disconnected on OpenSea Actual result: the wallet stays connected, you need to log out manually

Same situation for https://dydx.trade/ - the wallet is displayed as connected after disconnection on the Status side.

It seems this issue is relevant for dapps where a message signature is required when connecting.

alwx · 2024-07-22T11:31:12Z

It does seem like they don't handle the disconnect event properly.
This is what happens when I try it with opensea:

I see the toast in the Status app saying that the disconnection was successful
OpenSea doesn't show anything BUT in 10 seconds or so it starts experiencing issues with fetching my balance
if I refresh the page on OpenSea I see the following:

So it does look like we disconnected from OpenSea but they didn't process it correctly despite us sending the "disconnect" event to them.

@qoqobolo

qoqobolo · 2024-07-22T11:32:56Z

@alwx yep, looks like this. And I suspect there's nothing we can do about it, right?

alwx · 2024-07-22T11:33:01Z

Also, I see following errors in the devconsole of OpenSea:

alwx · 2024-07-22T11:33:55Z

@qoqobolo sadly, no. Once we sent the disconnect event, we cannot control the process anymore — we have no connection to the dapp itself and no way of telling them to really disconnect.

qoqobolo · 2024-07-22T11:35:31Z

@alwx gotcha.
Let's merge this PR then since everything except that case looks good to me. Thanks for your work!

…the list of connected dapps

alwx requested review from shivekkhurana and clauxx July 19, 2024 09:37

alwx requested a review from smohamedjavid July 19, 2024 09:37

alwx self-assigned this Jul 19, 2024

alwx force-pushed the bugfix/20797 branch from 3f12725 to 0feb2af Compare July 19, 2024 09:41

shivekkhurana approved these changes Jul 19, 2024

View reviewed changes

alwx added the request-manual-qa label Jul 19, 2024

smohamedjavid approved these changes Jul 19, 2024

View reviewed changes

clauxx approved these changes Jul 19, 2024

View reviewed changes

qoqobolo self-assigned this Jul 19, 2024

qoqobolo added the Tested - OK label Jul 22, 2024

alwx force-pushed the bugfix/20797 branch from 60df1e4 to 62e125e Compare July 22, 2024 13:02

Proper handling of disconnection, both from the dapp itself and from …

790ed40

…the list of connected dapps

alwx force-pushed the bugfix/20797 branch from 62e125e to 790ed40 Compare July 22, 2024 13:07

alwx merged commit 08b65cb into develop Jul 22, 2024
6 checks passed

alwx deleted the bugfix/20797 branch July 22, 2024 13:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817

WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817

alwx commented Jul 19, 2024

status-im-auto commented Jul 19, 2024 •

edited

Loading

shivekkhurana left a comment

status-im-auto commented Jul 19, 2024

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

clauxx left a comment

alwx commented Jul 19, 2024

status-im-auto commented Jul 19, 2024

Class TestWalletMultipleDevice:

qoqobolo commented Jul 19, 2024

qoqobolo commented Jul 22, 2024

ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea side

alwx commented Jul 22, 2024 •

edited

Loading

qoqobolo commented Jul 22, 2024

alwx commented Jul 22, 2024

alwx commented Jul 22, 2024

qoqobolo commented Jul 22, 2024

WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817

WC: Proper handling of disconnection, both from the dapp itself and from the list of connected dapps #20817

Conversation

alwx commented Jul 19, 2024

Platforms

status-im-auto commented Jul 19, 2024 • edited Loading

Jenkins Builds

shivekkhurana left a comment

Choose a reason for hiding this comment

status-im-auto commented Jul 19, 2024

71% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (5)

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

clauxx left a comment

Choose a reason for hiding this comment

alwx commented Jul 19, 2024

status-im-auto commented Jul 19, 2024

0% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

qoqobolo commented Jul 19, 2024

ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea side

qoqobolo commented Jul 22, 2024

ISSUE 1: Disconnection of the OpenSea dapp in Status doesn't result in disconnection on the Opesea side

alwx commented Jul 22, 2024 • edited Loading

qoqobolo commented Jul 22, 2024

alwx commented Jul 22, 2024

alwx commented Jul 22, 2024

qoqobolo commented Jul 22, 2024

status-im-auto commented Jul 19, 2024 •

edited

Loading

alwx commented Jul 22, 2024 •

edited

Loading