-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: assets sort order on bridge and assets screen #20813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (25)
|
631842b
to
9ae90d6
Compare
ulisesmac
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @OmarBasem ! 👍 👍
9ae90d6
to
1f95eca
Compare
1f95eca
to
ca9d18d
Compare
57% of end-end tests have passed
Failed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
smohamedjavid
approved these changes
Jul 22, 2024
cammellos
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix: assets sort order on bridge and assets screen (#20813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #20706
Summary
This PR fixes sort order of assets on bridge and select assets screen to be in descending order of balance.
Simple fix, skipping QA.
Demo
Before:
![](https://private-user-images.githubusercontent.com/29354102/350223998-7af61f25-9c30-440d-a492-23e21ed55e95.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NzM5MTAsIm5iZiI6MTcyNTU3MzYxMCwicGF0aCI6Ii8yOTM1NDEwMi8zNTAyMjM5OTgtN2FmNjFmMjUtOWMzMC00NDBkLWE0OTItMjNlMjFlZDU1ZTk1LmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwNVQyMjAwMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNGIzMjA1YzcwODZlZjI0YzlkNjYzZDBkMzBmNTZiNGY4NDJhZDk4YzdhYzU0Y2QxMzUzYzI2MGJhN2ZhMTBjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.fJQXmYEt_YljtP7tjzQybaQVvTgF_FaDv_JIM76oeRw)
After:
![](https://private-user-images.githubusercontent.com/29354102/350224013-013dabea-2878-465d-a552-fa38362e7281.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NzM5MTAsIm5iZiI6MTcyNTU3MzYxMCwicGF0aCI6Ii8yOTM1NDEwMi8zNTAyMjQwMTMtMDEzZGFiZWEtMjg3OC00NjVkLWE1NTItZmEzODM2MmU3MjgxLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwNVQyMjAwMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNmZhMzdlOGY2MjU1YmYwMTQ1Y2Q5Yzk2MTk5NWNmZmY3OGQyODE2OWIzMzZjZDIxMTdjY2IwZDdlNjFhMjZjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.J-4OLNSJa1wKfFFknHHmYKTr3K4z7rI_WbpMOJv7sCw)