🦁 Fix issues with missing dapp images and dapp names #20811

shivekkhurana · 2024-07-18T18:33:18Z

fixes: #20732 #20731 #20769

Also fixes an issue in comment: #20693 (comment)

Title and Body	Image
Edit missing icons on various dapps on connection screen The image still feels a little weird because dydx is exposing transparent pngs.
If icon is not present, use initials avatar Also, if name is missing, it is computed from the url.
Apply name and image fixes in connected dapps list Also, make the dapp icons rounded to follow the designs.
Fix Dapp name and icon not showing on signing, transaction screen
Fix dapp connection info box not respecting theme colors

Status: Ready

status-im-auto · 2024-07-18T18:38:25Z

Jenkins Builds

Click to see older builds (29)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3c8228e`	#1	2024-07-18 18:38:24	~4 min	`tests`	📄`log`
✔️	`3c8228e`	#1	2024-07-18 18:40:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`3c8228e`	#1	2024-07-18 18:41:18	~7 min	`android`	🤖`apk` 📲
✔️	`3c8228e`	#1	2024-07-18 18:43:47	~10 min	`ios`	📱`ipa` 📲

✔️	`95ac352`	#3	2024-07-19 09:46:29	~5 min	`tests`	📄`log`
✔️	`95ac352`	#3	2024-07-19 09:48:57	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`95ac352`	#3	2024-07-19 09:49:55	~8 min	`android`	🤖`apk` 📲
❌	`95ac352`	#3	2024-07-19 09:50:57	~9 min	`ios`	📄`log`

✔️	`473267e`	#4	2024-07-19 10:10:33	~5 min	`tests`	📄`log`
✔️	`473267e`	#4	2024-07-19 10:13:45	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`473267e`	#4	2024-07-19 10:15:12	~10 min	`ios`	📱`ipa` 📲
✔️	`473267e`	#4	2024-07-19 10:15:19	~10 min	`android`	🤖`apk` 📲

❌	`b32d4a9`	#5	2024-07-22 11:19:58	~2 min	`tests`	📄`log`
✔️	`b32d4a9`	#5	2024-07-22 11:25:24	~8 min	`android`	🤖`apk` 📲
✔️	`b32d4a9`	#5	2024-07-22 11:25:39	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`b32d4a9`	#5	2024-07-22 11:26:18	~9 min	`ios`	📱`ipa` 📲

❌	`566d3dd`	#6	2024-07-22 12:30:09	~3 min	`tests`	📄`log`

❌	`b643e5d`	#7	2024-07-22 12:34:57	~2 min	`tests`	📄`log`
✔️	`b643e5d`	#7	2024-07-22 12:41:11	~9 min	`ios`	📱`ipa` 📲
✔️	`b643e5d`	#7	2024-07-22 12:41:23	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`b643e5d`	#7	2024-07-22 12:42:19	~10 min	`android`	🤖`apk` 📲

❌	`bc76649`	#9	2024-07-22 13:33:15	~3 min	`tests`	📄`log`
✔️	`bc76649`	#9	2024-07-22 13:36:29	~6 min	`android`	🤖`apk` 📲
✔️	`bc76649`	#9	2024-07-22 13:37:38	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`bc76649`	#9	2024-07-22 13:39:48	~9 min	`ios`	📱`ipa` 📲

❌	`fa788f8`	#10	2024-07-22 14:02:21	~7 min	`tests`	📄`log`
✔️	`fa788f8`	#10	2024-07-22 14:04:01	~9 min	`ios`	📱`ipa` 📲
✔️	`fa788f8`	#10	2024-07-22 14:05:40	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`fa788f8`	#10	2024-07-22 14:06:51	~12 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`a7b83d8`	#11	2024-07-22 15:38:09	~9 min	`ios`	📱`ipa` 📲
✔️	`a7b83d8`	#11	2024-07-22 15:40:03	~11 min	`tests`	📄`log`
✔️	`a7b83d8`	#11	2024-07-22 15:41:26	~12 min	`android`	🤖`apk` 📲
✔️	`a7b83d8`	#11	2024-07-22 15:42:00	~13 min	`android-e2e`	🤖`apk` 📲

✔️	`829b189`	#12	2024-07-23 11:30:19	~7 min	`tests`	📄`log`
✔️	`829b189`	#12	2024-07-23 11:31:21	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`829b189`	#12	2024-07-23 11:32:07	~8 min	`android`	🤖`apk` 📲
✔️	`829b189`	#12	2024-07-23 11:32:56	~9 min	`ios`	📱`ipa` 📲

clauxx

Looks good!

src/status_im/contexts/wallet/wallet_connect/events.cljs

status-im-auto · 2024-07-22T14:51:20Z

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 1
Passed tests: 6

IDs of expected to fail tests: 727232

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch`
Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox`

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (6)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

pavloburykh · 2024-07-22T16:14:33Z

@shivekkhurana thanks for the PR.

ISSUE 1 App and Account names are not aligned on signing request screen (Android)

Reproducing on Android 12, Samsung Galaxy A52

Below is an example from https://trade.dydx.exchange/portfolio/overview?utm_source=dydx-website

Steps:

Scan wallet connect QR code
Proceed with signing connection requests triggered by dApp
Pay attention at the title within requests modal

Actual result: App name is not aligned. Account name background is overlapping the above text of the title.

Expected result: screenshot from IOS

pavloburykh · 2024-07-22T16:39:01Z

ISSUE 2 Long dApp names are broken within request modal

Here is an example from OpenSea https://opensea.io/

shivekkhurana · 2024-07-22T16:50:33Z

Issue 1
We already have this logged separately and Alex is working on it https://github.com/orgs/status-im/projects/65/views/39?sliceBy%5Bvalue%5D=2.30.0+Beta&pane=issue&itemId=70985293

Issue 2
I have asked Alisher for design directions and will act as soon as he responds.

pavloburykh · 2024-07-23T11:21:59Z

@shivekkhurana thanks for the PR. Except ISSUE 1 and 2 PR looks good to me. If those issues are being handled separately - PR is ready for merge.

shivekkhurana force-pushed the shivekkhurana/missing-dapp-metadata branch 2 times, most recently from 566d3dd to b643e5d Compare July 22, 2024 12:31

shivekkhurana marked this pull request as ready for review July 22, 2024 12:32

shivekkhurana self-assigned this Jul 22, 2024

shivekkhurana requested review from alwx and clauxx July 22, 2024 12:37

clauxx approved these changes Jul 22, 2024

View reviewed changes

src/status_im/contexts/wallet/wallet_connect/events.cljs Outdated Show resolved Hide resolved

shivekkhurana added the request-manual-qa label Jul 22, 2024

This was linked to issues Jul 22, 2024

🧮 DyDx exchange doesn't show the app name signing screen with wallet-connect #20731

Closed

WalletConnect: missing icon/name on certain dApps #20769

Closed

shivekkhurana added 6 commits July 22, 2024 15:29

🦁 Beast mode

0fef716

🗑️ Remove prn calls

29491b3

🌎 Add utils to remove http:// prefix

e4018b1

⏭️ Extracted name and avatar computation

e715b41

🧹 Cleanup

0e5b7a0

✏️ Fix lint and remove REPL flow

bc76649

shivekkhurana force-pushed the shivekkhurana/missing-dapp-metadata branch from cee159c to bc76649 Compare July 22, 2024 13:29

❌ Remove broken test

fa788f8

🖊️ Fix lint

a7b83d8

pavloburykh added the Tested - Issues label Jul 22, 2024

pavloburykh mentioned this pull request Jul 23, 2024

Undefined is not a function when declining connection request #20796

Closed

pavloburykh added Tested - OK and removed Tested - Issues labels Jul 23, 2024

Merge branch 'develop' into shivekkhurana/missing-dapp-metadata

829b189

shivekkhurana mentioned this pull request Jul 23, 2024

🎴 Long dApp names are broken within request modal #20859

Closed

shivekkhurana merged commit 3bb7c30 into develop Jul 23, 2024
6 checks passed

shivekkhurana deleted the shivekkhurana/missing-dapp-metadata branch July 23, 2024 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🦁 Fix issues with missing dapp images and dapp names #20811

🦁 Fix issues with missing dapp images and dapp names #20811

shivekkhurana commented Jul 18, 2024 •

edited

Loading

status-im-auto commented Jul 18, 2024 •

edited

Loading

clauxx left a comment

status-im-auto commented Jul 22, 2024

Class TestWalletOneDevice:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

pavloburykh commented Jul 22, 2024

pavloburykh commented Jul 22, 2024

shivekkhurana commented Jul 22, 2024

pavloburykh commented Jul 23, 2024

🦁 Fix issues with missing dapp images and dapp names #20811

🦁 Fix issues with missing dapp images and dapp names #20811

Conversation

shivekkhurana commented Jul 18, 2024 • edited Loading

status-im-auto commented Jul 18, 2024 • edited Loading

Jenkins Builds

clauxx left a comment

Choose a reason for hiding this comment

status-im-auto commented Jul 22, 2024

86% of end-end tests have passed

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (6)

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

pavloburykh commented Jul 22, 2024

ISSUE 1 App and Account names are not aligned on signing request screen (Android)

pavloburykh commented Jul 22, 2024

ISSUE 2 Long dApp names are broken within request modal

shivekkhurana commented Jul 22, 2024

pavloburykh commented Jul 23, 2024

shivekkhurana commented Jul 18, 2024 •

edited

Loading

status-im-auto commented Jul 18, 2024 •

edited

Loading