-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch-only collectibles should not be included on the main wallet page by default #20735 #20761
Watch-only collectibles should not be included on the main wallet page by default #20735 #20761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins BuildsClick to see older builds (24)
|
hi @ulisesmac Once, the inclusion of watch-only account assets on the overall wallet page was discussed here. After that, @qoqobolo discussed with the design team (in Montenegro, if I am not mistaken) before issue creation, and they agreed that by default, the assets of watch-only accounts should not be included in the overall wallet. |
Hi @mmilad75 thank you for PR. take a look found issues: PR_ISSUE 1: Collectibles are not shown when a watch-only account with collectibles is openedSteps:
Actual result:No collectibles are shown for watch only account when current account is opened saved.mp4Expected result:Collectibles should be shown which belongs to the watch only account when the current account is opened. |
PR_ISSUE 2: Count of Multi-Collectibles from Watch-Only Account is combined with Regular accountSteps:
Actual result:The count of collectibles from the watch-only account is combined with the collectibles of the regular account on the wallet overview page. watchonlycombined.mp4Expected result:The count of collectibles from the watch-only account should not be combined with the collectibles of the regular account on the wallet overview page. OS:IOS, Android Devices:
|
f090cc5
to
ad77d15
Compare
@VolodLytvynenko Hi Volodymyr. Thanks for testing. The issues are fixed now. Please check again |
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
86% of end-end tests have passed
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (6)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
|
Hi @mmilad75 issues are fixed. PR is ready to be merged. Thank you for your work! |
This PR removes the watch-only collectibles from the list of collectibles in the wallet home screen.
I renamed
:wallet/request-collectibles-for-all-accounts
event to:wallet/request-collectibles-for-owned-accounts
and:wallet/all-collectibles-list
to:wallet/owned-collectibles-list
. They were only used in the wallet home page, so it was secure to rename it.I could've created a new event to handle all owned collectibles, but it the
:wallet/all-collectibles-list
was not used any where else so it would become an unused code.fixes #20735