Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap select account drawer #20750

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

ajayesivan
Copy link
Contributor

fixes #20334
comment: # (Please replace ... with your information. Remove < and >)
comment: # (To auto-close issue on merge, please insert the related issue number after # i.e fixes #566)

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number

otherwise

fixes #...

Summary

...

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Review notes

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • 1-1 chats
  • public chats
  • group chats
  • wallet / transactions
  • dapps / app browsing
  • account recovery
  • new account
  • user profile updates
  • networks
  • mailservers
  • fleet
  • bootnodes
Non-functional
  • battery performance
  • CPU performance / speed of the app
  • network consumption

Steps to test

  • Open Status
  • ...
  • Step 3, etc.

Before and after screenshots comparison

Figma (if available) iOS (if available) Android (if available)
Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after. Please embed Image/Video here of the before and after.

status: ready

@ajayesivan ajayesivan self-assigned this Jul 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jul 15, 2024

Jenkins Builds

Click to see older builds (32)
Commit #️⃣ Finished (UTC) Duration Platform Result
8d4bbcf #1 2024-07-15 10:29:59 ~4 min tests 📄log
✔️ 8d4bbcf #1 2024-07-15 10:32:43 ~6 min android-e2e 🤖apk 📲
✔️ 8d4bbcf #1 2024-07-15 10:33:24 ~7 min android 🤖apk 📲
✔️ 8d4bbcf #1 2024-07-15 10:35:00 ~9 min ios 📱ipa 📲
dcb8e56 #2 2024-07-20 09:16:50 ~2 min tests 📄log
✔️ dcb8e56 #2 2024-07-20 09:21:59 ~7 min android-e2e 🤖apk 📲
✔️ dcb8e56 #2 2024-07-20 09:22:06 ~7 min android 🤖apk 📲
✔️ dcb8e56 #2 2024-07-20 09:23:16 ~8 min ios 📱ipa 📲
92ec543 #3 2024-07-24 12:11:18 ~2 min tests 📄log
✔️ 92ec543 #3 2024-07-24 12:17:02 ~8 min android-e2e 🤖apk 📲
✔️ 92ec543 #3 2024-07-24 12:17:07 ~8 min android 🤖apk 📲
✔️ 92ec543 #3 2024-07-24 12:17:11 ~8 min ios 📱ipa 📲
cddf6d4 #4 2024-07-25 06:21:47 ~2 min tests 📄log
✔️ cddf6d4 #4 2024-07-25 06:25:09 ~6 min android-e2e 🤖apk 📲
✔️ cddf6d4 #4 2024-07-25 06:26:27 ~7 min android 🤖apk 📲
✔️ cddf6d4 #4 2024-07-25 06:28:02 ~9 min ios 📱ipa 📲
913aaf1 #5 2024-07-25 13:19:46 ~2 min tests 📄log
✔️ 913aaf1 #5 2024-07-25 13:24:16 ~6 min android 🤖apk 📲
✔️ 913aaf1 #5 2024-07-25 13:24:56 ~7 min android-e2e 🤖apk 📲
913aaf1 #5 2024-07-25 13:27:28 ~10 min ios 📄log
751178d #6 2024-07-25 14:21:28 ~4 min tests 📄log
✔️ 751178d #6 2024-07-25 14:25:29 ~8 min android-e2e 🤖apk 📲
✔️ 751178d #6 2024-07-25 14:25:49 ~8 min ios 📱ipa 📲
✔️ 751178d #6 2024-07-25 14:26:20 ~9 min android 🤖apk 📲
3b0c477 #7 2024-07-26 05:57:15 ~2 min tests 📄log
✔️ 3b0c477 #7 2024-07-26 06:02:16 ~7 min android 🤖apk 📲
✔️ 3b0c477 #7 2024-07-26 06:02:19 ~7 min android-e2e 🤖apk 📲
✔️ 3b0c477 #7 2024-07-26 06:03:54 ~8 min ios 📱ipa 📲
✔️ 0e7052e #8 2024-07-26 06:15:56 ~4 min tests 📄log
✔️ 0e7052e #8 2024-07-26 06:17:46 ~6 min android 🤖apk 📲
✔️ 0e7052e #8 2024-07-26 06:18:49 ~7 min android-e2e 🤖apk 📲
✔️ 0e7052e #8 2024-07-26 06:20:09 ~8 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c0e92e1 #9 2024-07-26 09:20:49 ~6 min android 🤖apk 📲
✔️ c0e92e1 #9 2024-07-26 09:21:49 ~7 min android-e2e 🤖apk 📲
✔️ c0e92e1 #9 2024-07-26 09:26:16 ~11 min ios 📱ipa 📲
✔️ 5ad4fb2 #10 2024-07-26 09:31:41 ~4 min tests 📄log
✔️ 5ad4fb2 #10 2024-07-26 09:35:49 ~8 min android-e2e 🤖apk 📲
✔️ 5ad4fb2 #10 2024-07-26 09:35:50 ~8 min android 🤖apk 📲
✔️ 5ad4fb2 #10 2024-07-26 09:37:29 ~10 min ios 📱ipa 📲

@ajayesivan ajayesivan force-pushed the 20334-account-selection-drawer branch 6 times, most recently from 751178d to 3b0c477 Compare July 26, 2024 05:54
@ajayesivan ajayesivan force-pushed the 20334-account-selection-drawer branch from c0e92e1 to 5ad4fb2 Compare July 26, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: REVIEW
Development

Successfully merging this pull request may close these issues.

Account Selection Drawer (From Setup Swap screen)
2 participants