Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't delete notification by last-message id #20744

Closed
wants to merge 1 commit into from
Closed

fix: don't delete notification by last-message id #20744

wants to merge 1 commit into from

Conversation

yqrashawn
Copy link
Contributor

status-im/status-go@1ef2434...33d74c5

status-go PR status-im/status-go#5520

fixes #17052

Summary

details at #17052 (comment)

Platforms

  • Android
  • iOS

Areas that maybe impacted

delete notification when deleting message

Steps to test

  • in a community channel
  • user A mention user B 3 times
  • user B should see 1, 2, 3 unread notification in activity center
  • user A delete last mention
  • user B should see 2 unread notifications in activity center

status: ready

@yqrashawn yqrashawn self-assigned this Jul 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jul 15, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 34a3647 #1 2024-07-15 06:43:46 ~5 min tests 📄log
✔️ 34a3647 #1 2024-07-15 06:44:46 ~6 min android-e2e 🤖apk 📲
✔️ 34a3647 #1 2024-07-15 06:47:23 ~9 min android 🤖apk 📲
✔️ 34a3647 #1 2024-07-15 06:49:38 ~11 min ios 📱ipa 📲
✔️ b693210 #3 2024-07-18 07:09:21 ~5 min tests 📄log
✔️ b693210 #3 2024-07-18 07:10:27 ~6 min android-e2e 🤖apk 📲
✔️ b693210 #3 2024-07-18 07:12:48 ~8 min android 🤖apk 📲
✔️ b693210 #3 2024-07-18 07:16:07 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 36fa1c3 #4 2024-07-19 06:21:38 ~4 min tests 📄log
✔️ 36fa1c3 #4 2024-07-19 06:25:35 ~8 min android 🤖apk 📲
✔️ 36fa1c3 #4 2024-07-19 06:25:38 ~8 min android-e2e 🤖apk 📲
✔️ 36fa1c3 #4 2024-07-19 06:26:51 ~10 min ios 📱ipa 📲
✔️ ba16e1a #5 2024-07-22 01:39:47 ~5 min tests 📄log
✔️ ba16e1a #5 2024-07-22 01:42:17 ~7 min android 🤖apk 📲
✔️ ba16e1a #5 2024-07-22 01:42:25 ~7 min android-e2e 🤖apk 📲
✔️ ba16e1a #5 2024-07-22 01:45:30 ~10 min ios 📱ipa 📲

@yqrashawn yqrashawn marked this pull request as draft July 15, 2024 06:46
@yqrashawn
Copy link
Contributor Author

not ready, need to update other notifications's last message

@yqrashawn
Copy link
Contributor Author

CleanShot.2024-07-18.at.15.01.49.mp4

@yqrashawn yqrashawn force-pushed the fix/donot-delete-notification-by-last-message-id branch 3 times, most recently from b693210 to 36fa1c3 Compare July 19, 2024 06:16
@yqrashawn yqrashawn marked this pull request as ready for review July 19, 2024 06:17
@yqrashawn
Copy link
Contributor Author

ready for review now

@yqrashawn yqrashawn force-pushed the fix/donot-delete-notification-by-last-message-id branch from 36fa1c3 to ba16e1a Compare July 22, 2024 01:34
@yqrashawn
Copy link
Contributor Author

next up: status-im/status-go#5520 (comment)

@yqrashawn yqrashawn removed their assignment Aug 6, 2024
@yqrashawn yqrashawn removed their assignment Aug 19, 2024
@seanstrom seanstrom mentioned this pull request Sep 2, 2024
Open
2 tasks
@seanstrom
Copy link
Member

Closing in favour of this PR: #21157

@seanstrom seanstrom closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmotta ilmotta ilmotta approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees
No one assigned
Labels
status-go
Projects
Pipeline for QA
Status: DONE
Milestone
No milestone
5 participants
@yqrashawn @status-im-auto @seanstrom @ilmotta @flexsurfer