feat: set spending cap screen #20727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (56)
|
briansztamfater
force-pushed
the
feat/set-spending-cap-ui
branch
12 times, most recently
from
af8ed51
to
c9b99ec
Compare
briansztamfater
changed the title
briansztamfater
force-pushed
the
feat/set-spending-cap-ui
branch
3 times, most recently
from
dbca863
to
4c8af0d
Compare
briansztamfater
requested review from
ajayesivan,
smohamedjavid,
mohsen-ghafouri,
vkjr and
J-Son89
and removed request for
smohamedjavid
|
Error after slide to swap: |
mohsen-ghafouri
approved these changes
Jul 18, 2024
| {:footer-container-padding 0 | ||
| :header [quo/page-nav | ||
| {:icon-name :i/close | ||
| :on-press on-close-action |
There was a problem hiding this comment.
Suggested change
| :on-press on-close-action | |
| :on-press navigation/navigate-back |
from this package [utils.navigation :as navigation]
briansztamfater
force-pushed
the
feat/set-spending-cap-ui
branch
from
4c8af0d
to
f07f0be
Compare
@ajayesivan Fixed the issue and added a temporary alert to prevent the error. |
|
Hi @briansztamfater ! Is it correct that this PR should skip manual QA part? |
HI @mariia-skrypnyk! QA is not strictly required in this case because this PR only includes screen UI with hardcoded data, so it is better to finish integration before involving QA. |
briansztamfater
force-pushed
the
feat/set-spending-cap-ui
branch
from
f07f0be
to
db69a3a
Compare
57% of end-end tests have passedFailed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (4)Click to expandClass TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
|
@status-im/mobile-qa Can you check failed e2e tests please? Thanks in advance! |
71% of end-end tests have passedFailed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
|
|
@briansztamfater thanks! PR is ready for merge. |
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
feat/set-spending-cap-ui
branch
from
db69a3a
to
221e281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20336
Summary
This PR implements Set Spending Cap screen, no backend integration yet and some data is hardcoded for now, but UI should be functional and most of the logic should be in place
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready