-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set spending cap screen #20727
Conversation
Jenkins BuildsClick to see older builds (56)
|
af8ed51
to
c9b99ec
Compare
dbca863
to
4c8af0d
Compare
Error after slide to swap: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small comment :)
{:footer-container-padding 0 | ||
:header [quo/page-nav | ||
{:icon-name :i/close | ||
:on-press on-close-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:on-press on-close-action | |
:on-press navigation/navigate-back |
from this package [utils.navigation :as navigation]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
4c8af0d
to
f07f0be
Compare
@ajayesivan Fixed the issue and added a temporary alert to prevent the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 🙌
Hi @briansztamfater ! Is it correct that this PR should skip manual QA part? |
HI @mariia-skrypnyk! QA is not strictly required in this case because this PR only includes screen UI with hardcoded data, so it is better to finish integration before involving QA. |
f07f0be
to
db69a3a
Compare
57% of end-end tests have passed
Failed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (4)Click to expandClass TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
@status-im/mobile-qa Can you check failed e2e tests please? Thanks in advance! |
71% of end-end tests have passed
Failed tests (1)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
|
@briansztamfater thanks! PR is ready for merge. |
Signed-off-by: Brian Sztamfater <brian@status.im>
db69a3a
to
221e281
Compare
fixes #20336
Summary
This PR implements Set Spending Cap screen, no backend integration yet and some data is hardcoded for now, but UI should be functional and most of the logic should be in place
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready