Quo2 Wallet: Token Value #16880
Merged
Quo2 Wallet: Token Value #16880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
requested review from
erikseppanen,
briansztamfater,
smohamedjavid,
J-Son89,
rasom and
mmilad75
Jenkins BuildsClick to see older builds (42)
|
src/status_im2/contexts/quo_preview/list_items/token_value.cljs
Outdated
Show resolved
Hide resolved
|
Hey @Francesca-G, a design review please :) Component is under list-items category |
| (let [state (reagent/atom {:token :snt | ||
| :state :default | ||
| :status :empty | ||
| :color :blue |
There was a problem hiding this comment.
We need to replace the color key with the customization-color key (and inside the component too) as it's the standard key across the codebase.
Additionally, the (preview/customization-color-option) uses customization-color key. Any changes in the color will not be reflected in the component.
There was a problem hiding this comment.
Fixed it. Thanks @smohamedjavid 👍
J-Son89
reviewed
Aug 4, 2023
Francesca-G
reviewed
Aug 4, 2023
OmarBasem
force-pushed
the
quo2/token-value
branch
from
73014e4
to
626ed0b
Compare
Francesca-G
approved these changes
Aug 4, 2023
OmarBasem
force-pushed
the
quo2/token-value
branch
from
602b54f
to
d0c060b
Compare
mmilad75
pushed a commit
that referenced
this pull request
Aug 7, 2023
* feat: quo2 wallet - Token Value
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Aug 29, 2023
* feat: quo2 wallet - Token Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16833
This PR implements Token Value list item component.
Designs.
Preview:
