Fix for multiple header spacings on onboarding screens #15640

alwx · 2023-04-13T10:38:30Z

⚠️ I didn't focus on "Profile password" screen because it's terribly structured and because it has a scroll view that doesn't work properly — it looks more like a prototype at this stage. This screen should be re-made the same way as "Create profile" screen — with all the appropriate spacings and listeners.

Platforms

Android
iOS

Areas that maybe impacted

Functional

onboarding

status: ready

status-im-auto · 2023-04-13T10:42:34Z

Jenkins Builds

Click to see older builds (36)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`c424ec9`	#1	2023-04-13 10:42:34	~3 min	`tests`	📄`log`
✔️	`c424ec9`	#1	2023-04-13 10:44:44	~5 min	`android`	🤖`apk` 📲
✔️	`c424ec9`	#1	2023-04-13 10:45:08	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c424ec9`	#1	2023-04-13 10:45:52	~7 min	`ios`	📱`ipa` 📲

❌	`5a500c5`	#2	2023-04-13 10:51:35	~3 min	`tests`	📄`log`
✔️	`5a500c5`	#2	2023-04-13 10:53:31	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`5a500c5`	#2	2023-04-13 10:53:57	~6 min	`android`	🤖`apk` 📲
✔️	`5a500c5`	#2	2023-04-13 10:54:44	~6 min	`ios`	📱`ipa` 📲

❌	`ba543c3`	#4	2023-04-13 11:48:46	~3 min	`tests`	📄`log`
✔️	`ba543c3`	#4	2023-04-13 11:52:19	~6 min	`android`	🤖`apk` 📲
✔️	`ba543c3`	#4	2023-04-13 11:52:20	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ba543c3`	#4	2023-04-13 11:53:32	~7 min	`ios`	📱`ipa` 📲

✔️	`9a6203a`	#6	2023-04-13 12:00:36	~5 min	`android`	🤖`apk` 📲
✔️	`9a6203a`	#6	2023-04-13 12:00:41	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`9a6203a`	#6	2023-04-13 12:01:28	~6 min	`tests`	📄`log`
✔️	`9a6203a`	#6	2023-04-13 12:03:23	~8 min	`ios`	📱`ipa` 📲

✔️	`5cc36c5`	#7	2023-04-13 22:30:06	~5 min	`tests`	📄`log`
✔️	`5cc36c5`	#7	2023-04-13 22:30:34	~6 min	`android`	🤖`apk` 📲
✔️	`5cc36c5`	#7	2023-04-13 22:30:40	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`5cc36c5`	#7	2023-04-13 22:31:19	~7 min	`ios`	📱`ipa` 📲

✔️	`8d59255`	#8	2023-04-14 12:01:42	~6 min	`tests`	📄`log`
✔️	`8d59255`	#8	2023-04-14 12:01:48	~6 min	`android`	🤖`apk` 📲
✔️	`8d59255`	#8	2023-04-14 12:01:53	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`8d59255`	#8	2023-04-14 12:02:19	~6 min	`ios`	📱`ipa` 📲

✔️	`07596bf`	#9	2023-04-17 07:37:32	~5 min	`tests`	📄`log`
✔️	`07596bf`	#9	2023-04-17 07:38:05	~6 min	`android`	🤖`apk` 📲
✔️	`07596bf`	#9	2023-04-17 07:38:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`07596bf`	#9	2023-04-17 07:39:00	~7 min	`ios`	📱`ipa` 📲

✔️	`36f5632`	#10	2023-04-18 10:08:45	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`36f5632`	#10	2023-04-18 10:08:58	~6 min	`android`	🤖`apk` 📲
✔️	`36f5632`	#10	2023-04-18 10:09:01	~6 min	`tests`	📄`log`
✔️	`36f5632`	#10	2023-04-18 10:18:25	~15 min	`ios`	📱`ipa` 📲

✔️	`5322ce8`	#11	2023-04-18 16:39:48	~6 min	`android`	🤖`apk` 📲
✔️	`5322ce8`	#11	2023-04-18 16:40:10	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`5322ce8`	#11	2023-04-18 16:40:15	~6 min	`tests`	📄`log`
✔️	`5322ce8`	#11	2023-04-18 16:41:30	~7 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3769ad2`	#13	2023-04-19 08:30:53	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`3769ad2`	#13	2023-04-19 08:31:03	~5 min	`android`	🤖`apk` 📲
✔️	`3769ad2`	#13	2023-04-19 08:31:19	~6 min	`tests`	📄`log`
✔️	`3769ad2`	#13	2023-04-19 08:32:47	~7 min	`ios`	📱`ipa` 📲

✔️	`fba7b54`	#14	2023-04-19 12:06:52	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`fba7b54`	#14	2023-04-19 12:07:20	~6 min	`android`	🤖`apk` 📲
✔️	`fba7b54`	#14	2023-04-19 12:07:52	~6 min	`tests`	📄`log`
✔️	`fba7b54`	#14	2023-04-19 12:10:08	~9 min	`ios`	📱`ipa` 📲

alwx · 2023-04-17T07:31:43Z

Still waiting for this one to be reviewed :)

J-Son89

Nice one @alwx 😀

src/status_im2/contexts/onboarding/create_profile/view.cljs

src/status_im2/contexts/onboarding/create_password/view.cljs

status-im-auto · 2023-04-19T08:25:50Z

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850

Device 2: Find `Button` by `accessibility id`: `tab-recent`
Device 2: Tap on found: Button

medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

[[Blocked by 15500]]

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Passed tests (27)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

qoqobolo · 2023-04-19T11:16:17Z

Thanks @alwx, PR can be merged.

* Fix for onboarding header spacing * Style fixes; fix for enable-biometrics * Style fixes * Style fixes * Update for functional components

Fix for onboarding header spacing

c424ec9

Style fixes; fix for enable-biometrics

5a500c5

Parveshdhull assigned alwx Apr 13, 2023

alwx added 2 commits April 13, 2023 13:44

Style fixes

e4ea475

Merge branch 'develop' into bugfix/15628

ba543c3

alwx marked this pull request as ready for review April 13, 2023 11:45

alwx requested review from J-Son89 and flexsurfer April 13, 2023 11:45

alwx added 2 commits April 13, 2023 13:53

Style fixes

5a7fe8a

Merge branch 'develop' into bugfix/15628

9a6203a

alwx requested a review from siddarthkay April 13, 2023 12:08

alwx added 2 commits April 14, 2023 00:23

Merge branch 'develop' into bugfix/15628

5cc36c5

Merge branch 'develop' into bugfix/15628

8d59255

Parveshdhull mentioned this pull request Apr 14, 2023

[#15518]Show disclaimer during password creation #15650

Merged

alwx requested review from briansztamfater and ulisesmac April 17, 2023 07:31

Merge branch 'develop' into bugfix/15628

07596bf

J-Son89 approved these changes Apr 17, 2023

View reviewed changes

src/status_im2/contexts/onboarding/create_profile/view.cljs Show resolved Hide resolved

flexsurfer added the request-manual-qa label Apr 17, 2023

ulisesmac reviewed Apr 17, 2023

View reviewed changes

src/status_im2/contexts/onboarding/create_password/view.cljs Outdated Show resolved Hide resolved

alwx added 2 commits April 18, 2023 12:02

Merge branch 'develop' into bugfix/15628

36f5632

Merge branch 'develop' into bugfix/15628

5322ce8

alwx added 2 commits April 19, 2023 10:24

Update for functional components

ec47491

Merge branch 'develop' into bugfix/15628

3769ad2

qoqobolo self-assigned this Apr 19, 2023

qoqobolo added the Tested - OK label Apr 19, 2023

Merge branch 'develop' into bugfix/15628

fba7b54

alwx merged commit 3ca120c into develop Apr 19, 2023

alwx deleted the bugfix/15628 branch April 19, 2023 12:18

ibrkhalil pushed a commit that referenced this pull request Apr 20, 2023

Fix for multiple header spacings on onboarding screens (#15640)

109edd7

* Fix for onboarding header spacing * Style fixes; fix for enable-biometrics * Style fixes * Style fixes * Update for functional components

alwx added a commit that referenced this pull request Apr 28, 2023

Fix for multiple header spacings on onboarding screens (#15640)

bda9556

* Fix for onboarding header spacing * Style fixes; fix for enable-biometrics * Style fixes * Style fixes * Update for functional components

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for multiple header spacings on onboarding screens #15640

Fix for multiple header spacings on onboarding screens #15640

alwx commented Apr 13, 2023 •

edited

Loading

status-im-auto commented Apr 13, 2023 •

edited

Loading

alwx commented Apr 17, 2023

J-Son89 left a comment

status-im-auto commented Apr 19, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Apr 19, 2023

Fix for multiple header spacings on onboarding screens #15640

Fix for multiple header spacings on onboarding screens #15640

Conversation

alwx commented Apr 13, 2023 • edited Loading

Platforms

Areas that maybe impacted

Functional

status-im-auto commented Apr 13, 2023 • edited Loading

Jenkins Builds

alwx commented Apr 17, 2023

J-Son89 left a comment

Choose a reason for hiding this comment

status-im-auto commented Apr 19, 2023

93% of end-end tests have passed

Failed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Passed tests (27)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

qoqobolo commented Apr 19, 2023

alwx commented Apr 13, 2023 •

edited

Loading

status-im-auto commented Apr 13, 2023 •

edited

Loading