🤳🏻 Enable collectibles and NFT as profile picture #12615
Conversation
Jenkins BuildsClick to see older builds (52)
|
shivekkhurana
force-pushed
the
feat/nft-enable-and-nft-as-pfp
branch
from
6c7788f
to
6c9468e
Compare
📸 View Screenshot
|
|
@shivekkhurana Could you please make a minor edit to the Collectibles empty state: |
|
Also curious about the toast message. What flexibility do we have there when it comes to formatting? e.g. Are emoji's an option? |
Everything is allowed. All React components are valid toasts, however I cannot promise anything until I check. If you want emoji's send me a design (or a rough description) and I'll try it out. |
Awesome! I wasn't thinking of styling the component tbh, but thinking it's a good opportunity for more casual language. We don't use that often, because it's easy to go wrong. But this is a fun low-risk context: "Profile picture updated😎" |
97% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (65)Click to expand |
100% of end-end tests have passedPassed tests (2)Click to expand
|
|
@shivekkhurana
IOS build can't be built. |
|
@churik Do you have an error for ios builds? |
|
Can be found here: https://ci.status.im/job/status-react/job/prs/job/ios/job/PR-12615/7/console |
shivekkhurana
force-pushed
the
feat/nft-enable-and-nft-as-pfp
branch
2 times, most recently
from
e05af9c
to
2d3c7af
Compare
|
No idea why but doing |
|
@shivekkhurana thank you for PR! ISSUE 1: Missing translation in settings
ISSUE 2: Still can see amount of collectibles on Ropsten network, but they are not tappableSteps:
Expected result: Actual result:
ISSUE 3: Handling of collectibles without images
ISSUE 4: Number of collectibles on OpenSea website and in status app is differentSteps:
Expected result: ISSUE 5 (question): why the background color is black when you set collectible as profile photo?
|
shivekkhurana
force-pushed
the
feat/nft-enable-and-nft-as-pfp
branch
from
8b1cd24
to
8476227
Compare
1 - Fixed ✅2 - Fixed ✅3 - Added placeholders
|
|
@shivekkhurana thank you for the fixes! ISSUE4is reproducible; it is not only that particular account, but I also can see differences for another accounts (i.e. simona.eth on opensea has 179 items, in status.im 183 items are shown) ISSUE5 No sorting, so no way to find smth you need in random listBetter to sort them alphabetically. I suppose we can fix separately ISSUE 5, but not ISSUE 4. |
100% of end-end tests have passedPassed tests (1)Click to expand
|
ISSUE4Anthony and I did some detective work to find what the issue is. There are two aspects of the OpenSea api: The failing collections (MCP in this case) have 0 assets returned although the collection says 1 asset available. So the app stays stuck at loading state (grayish box with no icon). Rainbow works fine because the don't query collections API and simply fetch all assets (ie. fat payload) and then compute collections from all assets. We face a problem because we fetch assets on demand, and it gets stuck when there are 0 assets in the collection.
ISSUE5 No sorting, so no way to find smth you need in random listBetter to sort them alphabetically DONE ✅ Also addressed comments from Roman. I have not enabled it in release version yet, but I think its good to go in develop. That will allow a broader review. |
|
@qoqobolo Hey, this is ready to be re-re-tested. |
|
@shivekkhurana thanks for the fixes and for all this great work! |
shivekkhurana
force-pushed
the
feat/nft-enable-and-nft-as-pfp
branch
2 times, most recently
from
c407fe9
to
d21538a
Compare
New UI and re-frame handlers for setting pfp from url Add fake chain-id, connect the pfp upload backend to UI Add toast on setting pfp, new-new-new UI Show assets based on selected network Add horzontal padding to traits card a11y ids and pr review changes Added emoji in toast, fix chain id nill issue Restore Podfile Fix fix podfile Add placeholder images for collections, hide option to set pfp when image url is empty or ends in mp4 or svg Improvise missing designs Fix paddings New nu placeholders Sort collections by name Kinda fix issue 4 Fix lint Signed-off-by: Shivek Khurana <shivek@status.im>
shivekkhurana
force-pushed
the
feat/nft-enable-and-nft-as-pfp
branch
from
d21538a
to
389ce66
Compare
fixes #12613
Summary
Enable NFTs view (based on selected network, only works with mainnet and rinkyby)
Allow setting NFTs as Profile picture
View NFT details
TODO in next PR: Make NFT txns
Platforms
Areas that maybe impacted
Functional
status: Ready