Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EIP 1559 on ropsten #12369

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Enable EIP 1559 on ropsten #12369

merged 2 commits into from
Aug 20, 2021

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented Jul 26, 2021

Enable EIP 1559 on ropsten network.

This might require e2e test changes.

Testing

If you set custom fee when sending a transaction, you should see the new interface on ropsten.

Fixes: #12116

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 26, 2021

Jenkins Builds

Click to see older builds (129)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f4f97ae #1 2021-07-26 09:38:26 ~11 min android-e2e 📦apk 📲
✔️ f4f97ae #1 2021-07-26 09:40:26 ~13 min android 📦apk 📲
✔️ f4f97ae #1 2021-07-26 09:43:05 ~16 min ios 📦ipa 📲
✔️ ee8b2c4 #2 2021-07-27 10:03:23 ~14 min android-e2e 📦apk 📲
✔️ ee8b2c4 #2 2021-07-27 10:04:17 ~15 min ios 📦ipa 📲
✔️ ee8b2c4 #2 2021-07-27 10:06:03 ~17 min android 📦apk 📲
✔️ ee8b2c4 #3 2021-08-02 09:54:39 ~22 min ios 📦ipa 📲
✔️ 72bc64e #3 2021-08-04 10:08:41 ~12 min android 📦apk 📲
✔️ 72bc64e #4 2021-08-04 10:09:59 ~13 min ios 📦ipa 📲
✔️ 72bc64e #3 2021-08-04 10:10:24 ~14 min android-e2e 📦apk 📲
✔️ 8385f62 #5 2021-08-04 10:44:59 ~13 min ios 📦ipa 📲
✔️ 8385f62 #4 2021-08-04 10:45:48 ~14 min android 📦apk 📲
✔️ 8385f62 #4 2021-08-04 10:46:08 ~14 min android-e2e 📦apk 📲
✔️ 497d120 #6 2021-08-04 11:35:49 ~13 min ios 📦ipa 📲
✔️ 497d120 #5 2021-08-04 11:37:13 ~14 min android 📦apk 📲
✔️ 497d120 #5 2021-08-04 11:37:26 ~14 min android-e2e 📦apk 📲
✔️ 791b182 #6 2021-08-05 08:13:40 ~15 min android 📦apk 📲
✔️ 791b182 #6 2021-08-05 08:13:47 ~15 min android-e2e 📦apk 📲
✔️ 791b182 #7 2021-08-05 08:14:04 ~15 min ios 📦ipa 📲
✔️ a110129 #7 2021-08-05 09:58:37 ~11 min android-e2e 📦apk 📲
✔️ a110129 #7 2021-08-05 09:59:48 ~12 min android 📦apk 📲
✔️ 8c89720 #8 2021-08-05 10:03:15 ~12 min android 📦apk 📲
✔️ 8c89720 #8 2021-08-05 10:03:47 ~13 min android-e2e 📦apk 📲
✔️ 8c89720 #9 2021-08-05 10:10:33 ~20 min ios 📦ipa 📲
✔️ 1b2f80f #9 2021-08-05 10:09:54 ~12 min android-e2e 📦apk 📲
✔️ 1b2f80f #9 2021-08-05 10:14:04 ~17 min android 📦apk 📲
✔️ 1b2f80f #10 2021-08-05 10:30:03 ~32 min ios 📦ipa 📲
✔️ 049a892 #10 2021-08-05 11:53:50 ~14 min android 📦apk 📲
✔️ 049a892 #10 2021-08-05 11:53:52 ~14 min android-e2e 📦apk 📲
✔️ 049a892 #11 2021-08-05 11:54:06 ~14 min ios 📦ipa 📲
✔️ 087576e #12 2021-08-05 12:23:02 ~13 min ios 📦ipa 📲
✔️ 087576e #11 2021-08-05 12:23:11 ~14 min android 📦apk 📲
✔️ 087576e #11 2021-08-05 12:23:58 ~14 min android-e2e 📦apk 📲
✔️ 2253ea9 #12 2021-08-05 13:34:49 ~14 min android 📦apk 📲
✔️ 2253ea9 #13 2021-08-05 13:35:55 ~15 min ios 📦ipa 📲
✔️ 2253ea9 #12 2021-08-05 13:37:58 ~17 min android-e2e 📦apk 📲
✔️ cb2314d #13 2021-08-05 14:20:25 ~15 min android-e2e 📦apk 📲
✔️ cb2314d #14 2021-08-05 14:20:40 ~15 min ios 📦ipa 📲
✔️ cb2314d #13 2021-08-05 14:20:52 ~15 min android 📦apk 📲
✔️ 20c79c4 #14 2021-08-05 14:27:47 ~14 min android-e2e 📦apk 📲
✔️ 20c79c4 #14 2021-08-05 14:28:48 ~15 min android 📦apk 📲
✔️ 20c79c4 #15 2021-08-05 14:29:50 ~16 min ios 📦ipa 📲
✔️ f75d5f6 #16 2021-08-06 08:23:52 ~13 min ios 📦ipa 📲
✔️ f75d5f6 #15 2021-08-06 08:25:19 ~15 min android 📦apk 📲
✔️ f75d5f6 #15 2021-08-06 08:25:27 ~15 min android-e2e 📦apk 📲
✔️ 460330c #17 2021-08-07 11:34:08 ~13 min ios 📦ipa 📲
✔️ 460330c #16 2021-08-07 11:34:13 ~13 min android 📦apk 📲
✔️ 460330c #16 2021-08-07 11:34:16 ~13 min android-e2e 📦apk 📲
✔️ 32db027 #17 2021-08-10 06:45:36 ~11 min android-e2e 📦apk 📲
✔️ 32db027 #17 2021-08-10 06:51:32 ~17 min android 📦apk 📲
✔️ 32db027 #18 2021-08-10 06:53:06 ~18 min ios 📦ipa 📲
✔️ 5718107 #18 2021-08-10 09:17:44 ~17 min android-e2e 📦apk 📲
✔️ 5718107 #18 2021-08-10 09:19:55 ~19 min android 📦apk 📲
✔️ 5718107 #19 2021-08-10 09:20:16 ~19 min ios 📦ipa 📲
✔️ 2f319a0 #20 2021-08-11 05:47:49 ~13 min ios 📦ipa 📲
✔️ 2f319a0 #19 2021-08-11 05:51:35 ~17 min android-e2e 📦apk 📲
✔️ 2f319a0 #19 2021-08-11 05:51:47 ~17 min android 📦apk 📲
✔️ 6f49f86 #21 2021-08-11 07:23:54 ~14 min ios 📦ipa 📲
✔️ 6f49f86 #20 2021-08-11 07:23:59 ~14 min android-e2e 📦apk 📲
✔️ 6f49f86 #20 2021-08-11 07:24:05 ~14 min android 📦apk 📲
✔️ d0d9979 #22 2021-08-12 12:42:52 ~13 min ios 📦ipa 📲
✔️ d0d9979 #21 2021-08-12 12:44:26 ~15 min android 📦apk 📲
✔️ d0d9979 #21 2021-08-12 12:44:29 ~15 min android-e2e 📦apk 📲
✔️ 408e7ee #23 2021-08-12 17:13:28 ~17 min ios 📦ipa 📲
✔️ 408e7ee #22 2021-08-12 17:14:44 ~18 min android-e2e 📦apk 📲
✔️ 408e7ee #22 2021-08-12 17:14:44 ~18 min android 📦apk 📲
✔️ 149f9b5 #24 2021-08-12 19:12:48 ~13 min ios 📦ipa 📲
✔️ 149f9b5 #23 2021-08-12 19:13:03 ~14 min android 📦apk 📲
✔️ 149f9b5 #23 2021-08-12 19:13:04 ~14 min android-e2e 📦apk 📲
✔️ 83dcca0 #24 2021-08-13 06:44:30 ~14 min android 📦apk 📲
✔️ 83dcca0 #24 2021-08-13 06:44:40 ~14 min android-e2e 📦apk 📲
83dcca0 #25 2021-08-13 06:45:14 ~15 min ios 📄log
✔️ 24d57af #25 2021-08-13 07:56:40 ~11 min android-e2e 📦apk 📲
✔️ 24d57af #26 2021-08-13 08:00:55 ~15 min ios 📦ipa 📲
✔️ 24d57af #25 2021-08-13 08:01:55 ~16 min android 📦apk 📲
b4cbea0 #26 2021-08-13 09:53:29 ~14 min android-e2e 📄log
b4cbea0 #26 2021-08-13 09:53:44 ~14 min android 📄log
b4cbea0 #27 2021-08-13 09:56:53 ~17 min ios 📄log
✔️ 46b7582 #27 2021-08-13 13:04:13 ~14 min android-e2e 📦apk 📲
✔️ 46b7582 #27 2021-08-13 13:04:18 ~14 min android 📦apk 📲
✔️ 46b7582 #28 2021-08-13 13:06:58 ~17 min ios 📦ipa 📲
2173510 #28 2021-08-16 11:50:30 ~17 sec android-e2e 📄log
2173510 #28 2021-08-16 11:50:35 ~17 sec android 📄log
2173510 #29 2021-08-16 11:50:36 ~18 sec ios 📄log
0e92f35 #29 2021-08-16 12:11:50 ~20 sec android 📄log
0e92f35 #29 2021-08-16 12:11:50 ~21 sec android-e2e 📄log
0e92f35 #30 2021-08-16 12:11:53 ~23 sec ios 📄log
✔️ 6001019 #30 2021-08-16 14:03:39 ~14 min android 📦apk 📲
✔️ 6001019 #30 2021-08-16 14:03:48 ~14 min android-e2e 📦apk 📲
✔️ 6001019 #31 2021-08-16 14:13:34 ~24 min ios 📦ipa 📲
✔️ d8dc37c #31 2021-08-17 10:33:04 ~14 min android-e2e 📦apk 📲
✔️ d8dc37c #31 2021-08-17 10:33:22 ~15 min android 📦apk 📲
✔️ d8dc37c #32 2021-08-17 10:37:14 ~18 min ios 📦ipa 📲
✔️ 34be14e #32 2021-08-17 10:34:56 ~11 min android 📦apk 📲
✔️ 34be14e #32 2021-08-17 10:39:07 ~15 min android-e2e 📦apk 📲
✔️ 34be14e #33 2021-08-17 10:45:10 ~21 min ios 📦ipa 📲
✔️ a808bdc #33 2021-08-17 11:20:35 ~11 min android-e2e 📦apk 📲
✔️ a808bdc #33 2021-08-17 11:22:46 ~13 min android 📦apk 📲
✔️ a808bdc #34 2021-08-17 11:29:21 ~19 min ios 📦ipa 📲
30ed81b #34 2021-08-17 12:42:54 ~14 sec android-e2e 📄log
30ed81b #35 2021-08-17 12:42:57 ~13 sec ios 📄log
30ed81b #34 2021-08-17 12:43:02 ~21 sec android 📄log
✖️ edac649 #35 2021-08-17 13:26:25 ~13 min android-e2e 📦apk 📲
✖️ edac649 #35 2021-08-17 13:26:32 ~13 min android 📦apk 📲
✖️ edac649 #36 2021-08-17 13:32:20 ~19 min ios 📦ipa 📲
9ef8c17 #36 2021-08-19 08:20:24 ~29 sec android-e2e 📄log
9ef8c17 #36 2021-08-19 08:20:25 ~29 sec android 📄log
9ef8c17 #37 2021-08-19 08:20:25 ~29 sec ios 📄log
183715b #37 2021-08-19 08:35:42 ~26 sec android-e2e 📄log
183715b #37 2021-08-19 08:35:42 ~27 sec android 📄log
183715b #38 2021-08-19 08:35:43 ~27 sec ios 📄log
✖️ 5dafdcf #38 2021-08-19 08:58:00 ~14 min android-e2e 📦apk 📲
✖️ 5dafdcf #38 2021-08-19 08:58:04 ~14 min android 📦apk 📲
✖️ 5dafdcf #39 2021-08-19 08:59:16 ~15 min ios 📦ipa 📲
✖️ d062bd8 #39 2021-08-19 10:47:35 ~15 min android 📦apk 📲
✖️ d062bd8 #39 2021-08-19 10:50:41 ~18 min android-e2e 📦apk 📲
✖️ d062bd8 #40 2021-08-19 10:51:15 ~18 min ios 📦ipa 📲
✖️ 4460aa0 #40 2021-08-19 11:48:41 ~14 min android-e2e 📦apk 📲
✖️ 4460aa0 #40 2021-08-19 11:48:42 ~14 min android 📦apk 📲
✖️ 4460aa0 #41 2021-08-19 11:51:51 ~17 min ios 📦ipa 📲
✔️ c0db96e #41 2021-08-19 12:10:45 ~14 min android-e2e 📦apk 📲
✔️ c0db96e #41 2021-08-19 12:10:49 ~14 min android 📦apk 📲
✔️ c0db96e #42 2021-08-19 12:16:32 ~20 min ios 📦ipa 📲
✔️ 95aad39 #42 2021-08-20 07:41:17 ~14 min android-e2e 📦apk 📲
✔️ 95aad39 #42 2021-08-20 07:41:22 ~14 min android 📦apk 📲
✔️ 95aad39 #43 2021-08-20 07:42:56 ~16 min ios 📦ipa 📲
✔️ f6746fe #43 2021-08-20 08:01:48 ~14 min android 📦apk 📲
✔️ f6746fe #43 2021-08-20 08:02:00 ~14 min android-e2e 📦apk 📲
✔️ f6746fe #44 2021-08-20 08:05:08 ~18 min ios 📦ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ efebc53 #44 2021-08-20 09:10:51 ~18 min android 📦apk 📲
✔️ efebc53 #44 2021-08-20 09:10:52 ~18 min android-e2e 📦apk 📲
✔️ efebc53 #45 2021-08-20 09:11:06 ~18 min ios 📦ipa 📲
✔️ d556735 #45 2021-08-20 14:00:39 ~17 min android 📦apk 📲

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 71
Failed tests: 3
Passed tests: 68
IDs of failed tests: 6305,6265,6646 

Failed tests (3)

Click to expand
  • Rerun tests

  • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 1: *Find Button by accessibility id:* `send-my-status-button`
    Device 1: *Tap on found Button*

    'ChatView' object has no attribute 'image_chat_item'

    Device sessions

    2. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Decline transaction request and check that state is changed
    Device 1: =========================================================================

    Device 1: RequestCommand by xpath: `//*[@text="Request transaction"]` is not found on the screen

    Device sessions

    3. test_set_profile_picture, id: 6646

    Device 1: *Click system back button*
    Device 1: *Find Button by accessibility id:* `take-photo`

    Device 1: Button by accessibility id: `take-photo` is not found on the screen

    Device sessions

    Passed tests (68)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    3. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    4. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    5. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    6. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    7. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    8. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    9. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    10. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    11. test_delete_close_all_tabs, id: 5390
    Device sessions

    12. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    13. test_send_token_with_7_decimals, id: 5350
    Device sessions

    14. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    15. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    16. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    17. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_block_user_from_public_chat, id: 5786
    Device sessions

    21. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    25. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    26. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    27. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    28. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    31. test_long_press_to_delete_chat, id: 5319
    Device sessions

    32. test_copy_and_paste_messages, id: 5317
    Device sessions

    33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    34. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    35. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    40. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_can_add_existing_ens, id: 5502
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_collectible_from_wallet, id: 5346
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    60. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    61. test_pass_phrase_validation, id: 5363
    Device sessions

    62. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    63. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    64. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    65. test_fetching_balance_after_offline, id: 6237
    Device sessions

    66. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    67. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    68. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jul 27, 2021

    @cammellos
    maybe I did smth in a wrong way, but I see old interface on Ropsten if I recover multiaccount from seed on builds with f4f97ae

    FILE.2021-07-27.11.37.21.mp4

    I couldn't find any related setting in Advanced.

    @cammellos
    Copy link
    Contributor Author

    @churik sorry! I enabled it on dev, but I need to enable it on PRs as well, let me fix that, I'll let you know once I verify it.

    @churik churik self-assigned this Jul 27, 2021
    @churik
    Copy link
    Member

    churik commented Aug 2, 2021

    @cammellos @rasom
    at attempt to set custom network fee on Ropsten network got error:
    IMAGE 2021-08-02 11:39:19
    Logs:
    Status-debug-logs.zip

    @rasom
    Copy link
    Contributor

    rasom commented Aug 4, 2021

    @churik that issue is fixed

    @churik
    Copy link
    Member

    churik commented Aug 4, 2021

    can't sign transaction on ropsten - all failed with reason intrisic gas too low
    IMAGE 2021-08-04 14:01:36

    @rasom rasom force-pushed the features/suggest-tip branch 4 times, most recently from 8c89720 to 1b2f80f Compare August 5, 2021 09:56
    @churik
    Copy link
    Member

    churik commented Aug 5, 2021

    @rasom

    ISSUE 1: Can't sign transaction with default gas price on Ropsten

    Build with commit 1b2f80f
    IMAGE 2021-08-05 12:41:01
    IMAGE 2021-08-05 12:41:05
    Status-debug-logs.zip

    ISSUE 2: network fee is not calculated during some time after navigating to "Sending" screen

    Tested on build with commit 8c89720

    The easiest way to reproduce:

    1. switch to Ropsten
    2. fill amount and address with valid data
    3. Tap on sign
    4. On "sending" screen tap cancel
    5. try to start again

    Expected result:
    network fee is calculated

    Actual result:
    network fee is not calculated anymore during some time;

    FILE.2021-08-05.13.03.02.mp4

    @churik
    Copy link
    Member

    churik commented Aug 5, 2021

    ISSUE 3: can't sign transaction with keycard

    Tried on both mainnet and ropsten
    Steps:

    1. restore multiaccount from seed phrase with keycard
    2. try to sign transaction

    Expected result:
    tx is signed
    Actual result:
    nothing happened, processing
    OS: IOS, Android
    status_logs.zip

    @churik
    Copy link
    Member

    churik commented Aug 6, 2021

    @rasom on last build with f75d5f6 suggestion fee is 0 on Ropsten

    @status-im-auto
    Copy link
    Member

    40% of end-end tests have passed

    Total executed tests: 15
    Failed tests: 9
    Passed tests: 6
    
    IDs of failed tests: 5342,6251,6253,5309,6279,6263,6249,6293,6237 
    

    Failed tests (9)

    Click to expand
  • Rerun tests

  • 1. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    2. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    3. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    4. test_request_stt_from_daap, id: 5309

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Expected amount of confirmations is 3, in fact 3
    Device 1: *Wait for text element TransactionStatus to be equal to Confirmed*

    Device 1: 'Pending' is not equal to expected 'Confirmed' in 30 sec

    Device sessions

    6. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found Button*
    Device 2: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 2: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    7. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    8. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: *Tap on found Button*
    Device 1: *Find Button by xpath:* `//android.widget.SeekBar`

    Device 1: Button by xpath: `//android.widget.SeekBar` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    9. test_fetching_balance_after_offline, id: 6237

    Device 1: *Find Button by accessibility id:* `mobile-network-continue-syncing`
    Device 1: *Tap on found Button*

    Device 1: Button by accessibility id:* `conn-button-offline` is still visible on the screen after 100 seconds

    Device sessions

    Passed tests (6)

    Click to expand

    1. test_send_token_with_7_decimals, id: 5350
    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    3. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    4. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    5. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    6. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @Serhy
    Copy link
    Contributor

    Serhy commented Aug 11, 2021

    Issue 5
    App crashed when opening Network Fee bottom sheet when: a) sending transaction in 1-1 chat b) sending transaction in Dapp

    Reproduction 1:

    1. Recover account with ETHro
    2. Join 1-1 chat
    3. Send transaction in 1-1 chat and open Network Fee dialog before signing it
      Actual result: https://saucelabs.com/jobs/e54752589a764ca8ac904b1334e06a61?auth=1fcd0ee8ff8f39ac9ffaadbfa9e12421

    Screenshot 2021-08-11 at 20 52 49

    Reproduction 2:

    1. Recover account with ETHro
    2. Open simpledapp.eth
    3. Assets -> Request STT -> tap Network Fee

    Issue 6
    Is it possible to implement scroll in Max Priority Fee bottom sheet? In a case user wants to edit Gas amount - the field it hidden at the top of screen and typing possible in blind

    2021_08_11_20_40_31_trim.mp4

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 9
    Failed tests: 9
    Passed tests: 0
    
    IDs of failed tests: 5342,6251,6253,5309,6279,6263,6249,6293,6237 
    

    Failed tests (9)

    Click to expand
  • Rerun tests

  • 1. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    2. test_keycard_sign_message_and_transactions_from_daap, id: 6251

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    3. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    4. test_request_stt_from_daap, id: 5309

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen

    Device sessions

    6. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: *Tap on found Button*
    Device 2: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 2: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    7. test_keycard_request_stt_from_daap, id: 6249

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    8. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen; also Unexpected Alert is shown: 'gt() not a number: null'

    Device sessions

    9. test_fetching_balance_after_offline, id: 6237

    Device 1: *Tap on found Button*
    Device 1: *Find GasPriceInput by xpath:* `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]`

    Device 1: GasPriceInput by xpath: `(//*[@text="Gas limit"]/..//android.widget.EditText)[2]` is not found on the screen

    Device sessions

    @churik
    Copy link
    Member

    churik commented Aug 16, 2021

    Umbrella comment for issues (to be updated):

    • ISSUE 1: Can't sign transaction with default gas price on Ropsten
    • ISSUE 2: network fee is not calculated during some time after navigating to "Sending" screen
    • ISSUE 3: can't sign transaction with keycard
    • ISSUE 4: can't request STT or send any tx in simpledapp.eth
    • ISSUE 5: App crashed when opening Network Fee bottom sheet when: a) sending transaction in 1-1 chat b) sending transaction in Dapp
    • ISSUE 6: scroll in Max Priority Fee bottom sheet: will be handled separately, as doesn't relateto PR
    • ISSUE 7: Set max option doesn't set any value for ETH
    • ISSUE 8: Sometimes txs are stuck in "Pending" state in tx history: couldn't find a way to reproduce consistently
    • ISSUE 9: network fee is set to 0 if using Set max on ETH
    • ISSUE 10: Transaction underpriced at attempt to deploy contract from Dapp
    • ISSUE 11: No basic validation for custom network fee
    • ISSUE 12: Transaction underpriced at attempt to send assets in 1-1 chat from keycard multiaccount (MAINNET)
    • ISSUE 13: On the custom fee screen "Save" button is still available even user sets tip o invalid params (let's say, 0 or non-numeric)
    • ISSUE 14: On dap.ps on "Upvote" button tip limit / price limit is not set

    @churik
    Copy link
    Member

    churik commented Aug 16, 2021

    @rasom

    ISSUE 4, 5: still error when opening bottom sheet for sending transaction in 1-1 chat or in dapp

    Steps:

    1. restore multiaccount from seed phrase (with ETH on mainnet)
    2. start 1-1 chat
    3. send some ETH in 1-1 chat
      IMAGE 2021-08-16 13:23:12

    OS: IOS, Android
    Reproducible with simpledapp.eth on ropsten

    @churik
    Copy link
    Member

    churik commented Aug 16, 2021

    @rasom
    another error when tapping network feewhen requesting some assets in simpledapp.eth (Ropsten):
    IMAGE 2021-08-16 16:23:31
    Same error when tapping network fee when sending assets in 1-1 chat

    @churik
    Copy link
    Member

    churik commented Aug 16, 2021

    @rasom issue 6 is confirmed on Android 9 and Android 11, not relevant for IOS.

    @churik
    Copy link
    Member

    churik commented Aug 17, 2021

    ISSUE 7: Set max option doesn't set any value for ETH

    Steps:

    1. restore multiaccount from seed phrase (with ETH)
    2. open wallet > send tx
    3. tap on set max

    Expected result:
    max amount is set (taking into account default network fee)
    Actual result:
    nothing happend
    OS: IOS, Android

    @churik
    Copy link
    Member

    churik commented Aug 17, 2021

    ISSUE 8: Sometimes txs are stuck in "Pending" state in tx history.

    Seems that if ix is mined too fast (within 1-2 mins) it can stuck (only assumption though)
    IMAGE 2021-08-17 12:45:02
    TX 0.01 SALT is stuck in history in "Pending", relogin doesn't help.
    Balance was refreshed only after relogin
    Logs:
    Status-debug-logs.zip

    @churik
    Copy link
    Member

    churik commented Aug 17, 2021

    @rasom

    ISSUE 9: Network fee is set to 0 if using Set max on ETH

    Steps:

    1. restore multiaccount from seed phrase (with assets)
    2. tap Send
    3. tap Set max

    ISSUE 10: Transaction underpriced at attempt to deploy contract from Dapp

    e2e test blocker.
    https://saucelabs.com/jobs/fc7a789932fc430d9934fd7c96788a2f?auth=c9f75e5b352bb7352639e0d9b329d6c2
    Steps:

    1. restore multiaccount from seed phrase (with assets on Ropsten)
    2. open simpledapp.eth > Transactions > Deploy simple contract

    ISSUE 11: No basic validation for custom network fee, can't set Gas amount limit

    All fields (Gas amount limit, Per-gas tip limit fee, Per-Gas price limit) are empty when tapping on Ntwork fee, and Save button is available.

    I would suggest to have:

    1. Gas amount limit, Per-gas tip limit fee, Per-Gas price limit are filled with current values
    2. Save button is unavailable at least when fields have non-numeric values or empty.

    At attempt to set Gas amount limit (when typing in field) got an error:

    ISSUE 12: Transaction underpriced at attempt to send assets in 1-1 chat from keycard multiaccount (MAINNET)

    FILE.2021-08-18.10.51.24.mp4

    @rasom rasom force-pushed the features/suggest-tip branch 2 times, most recently from 4460aa0 to c0db96e Compare August 19, 2021 11:55
    @churik
    Copy link
    Member

    churik commented Aug 19, 2021

    Tested (IOS, Android, keycard/not keycard):

    • tx from dapp
    • all related e2e are fixed anad passed: results
    • tx from kk account: tokens, eth, 1-1 chat, wallet
    • buy sticker flow (didn't sign tx, as it costs > 50 USD), but checked that tip/base fee is set
    • buy ENS flow (didn't sign tx, as it costs > 50 USD), but checked that tip/base fee is set
    • collectibles are presented
    • sending custom tokens

    What's left:

    ISSUE 13: On the custom fee screen "Save" button is still available even user is set to invalid params (let's say, 0 or non-numeric).

    Therefore, users can try to sign these txs and will get an error i.e. 'Transaction underpriced'
    IMO would be nice to disable this button in such cases, but it is not a blocker for this feature

    ISSUE 14: On dap.ps on "Upvote" button tip limit / price limit is not set

    I'm not sure is it dap.ps issue or the issue on our side.
    IMAGE 2021-08-19 17:27:46
    Didn't try to sign tx, as it costs > 50 USD
    All PR issues are in umbrella comment #12369 (comment)

    More notes:

    • again saw ISSUE 8: Sometimes txs are stuck in "Pending" state in tx history: couldn't find a way to reproduce consistently - but couldn't reproduce it consistently (asked for a help, but no luck)
    • tx management (alfa) is working on mainnet now weird
      • on increase gas old tx will be not replaced in our history, so it will stay there forever
      • buttons "Increase" and "Cancel" are not responsible during some time after creating tx (until tx will appear on etherscan)
        So basically to use this feature is painful, as it seems rawer than it was when I tested it several weeks ago (but still working on a very basic level though)

    @cammellos would like to know your opinion: smth from mentioned above seems blocker for PR or it is good to go?
    Thank you!

    @cammellos
    Copy link
    Contributor Author

    @cammellos would like to know your opinion: smth from mentioned above seems blocker for PR or it is good to go?

    @churik they don't seem to be blocker to me, they should mostly affect advanced users, what do you think?

    @churik
    Copy link
    Member

    churik commented Aug 20, 2021

    @rasom fixed it, so I'm retesting and good to go

    @rasom rasom merged commit f940f8d into develop Aug 20, 2021
    @rasom rasom deleted the features/suggest-tip branch August 20, 2021 13:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Allow users to customize priority fee
    6 participants