-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable EIP 1559 on ropsten #12369
Enable EIP 1559 on ropsten #12369
Conversation
Jenkins BuildsClick to see older builds (129)
|
96% of end-end tests have passed
Failed tests (3)Click to expand
Passed tests (68)Click to expand |
@cammellos FILE.2021-07-27.11.37.21.mp4I couldn't find any related setting in Advanced. |
@churik sorry! I enabled it on dev, but I need to enable it on PRs as well, let me fix that, I'll let you know once I verify it. |
f4f97ae
to
ee8b2c4
Compare
@cammellos @rasom |
@churik that issue is fixed |
8c89720
to
1b2f80f
Compare
ISSUE 1: Can't sign transaction with default gas price on RopstenBuild with commit 1b2f80f ISSUE 2: network fee is not calculated during some time after navigating to "Sending" screenTested on build with commit 8c89720 The easiest way to reproduce:
Expected result: Actual result: FILE.2021-08-05.13.03.02.mp4 |
ISSUE 3: can't sign transaction with keycardTried on both mainnet and ropsten
Expected result: |
20c79c4
to
f75d5f6
Compare
40% of end-end tests have passed
Failed tests (9)Click to expand
Passed tests (6)Click to expand
|
Issue 5 Reproduction 1:
Reproduction 2:
Issue 6 2021_08_11_20_40_31_trim.mp4 |
149f9b5
to
83dcca0
Compare
0% of end-end tests have passed
Failed tests (9)Click to expand
|
Umbrella comment for issues (to be updated):
|
0e92f35
to
6001019
Compare
@rasom |
@rasom issue 6 is confirmed on Android 9 and Android 11, not relevant for IOS. |
ISSUE 7:
|
ISSUE 8: Sometimes txs are stuck in "Pending" state in tx history.Seems that if ix is mined too fast (within 1-2 mins) it can stuck (only assumption though) |
30ed81b
to
edac649
Compare
ISSUE 9: Network fee is set to 0 if using Set max on ETHSteps:
ISSUE 10:
|
4460aa0
to
c0db96e
Compare
Tested (IOS, Android, keycard/not keycard):
What's left: ISSUE 13: On the custom fee screen "Save" button is still available even user is set to invalid params (let's say, 0 or non-numeric).Therefore, users can try to sign these txs and will get an error i.e. 'Transaction underpriced' ISSUE 14: On dap.ps on "Upvote" button tip limit / price limit is not setI'm not sure is it dap.ps issue or the issue on our side. More notes:
@cammellos would like to know your opinion: smth from mentioned above seems blocker for PR or it is good to go? |
@churik they don't seem to be blocker to me, they should mostly affect advanced users, what do you think? |
@rasom fixed it, so I'm retesting and good to go |
f6746fe
to
efebc53
Compare
efebc53
to
d556735
Compare
d556735
to
f940f8d
Compare
Enable EIP 1559 on ropsten network.
This might require e2e test changes.
Testing
If you set custom fee when sending a transaction, you should see the new interface on ropsten.
Fixes: #12116
status: ready