Add a test case with multiple transactions and upstream node #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
suggested changes
Feb 5, 2018
| @@ -811,3 +811,103 @@ func (s *TransactionsTestSuite) TestEvictionOfQueuedTransactions() { | |||
| m.Unlock() | |||
| s.Zero(txQueue.Count(), "transaction count should be zero: %d", txQueue.Count()) | |||
| } | |||
|
|
|||
| func (s *TransactionsTestSuite) TestCompleteMultipleQueuedTransactionsUpstream() { | |||
There was a problem hiding this comment.
looks good, but please make it DRY :)
There was a problem hiding this comment.
Done, added setupUpstreamNode, setupLocalNode and sendConcurrentTransactions, PTAL.
dshulyak
approved these changes
Feb 5, 2018
|
@fgimenez thanks a lot for making our test suite better! ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case with multiple transactions and upstream node.
As suggested by #613 the test is based on
TestCompleteMultipleQueuedTransactionsfor concurrent transactions andTestCallRPCSendTransactionUpstreamfor upstream node initialization. I've increased the number of transactions in order to try to reproduce the problem described in #538, but the test passes consistently, is this correct? does the test need some further tweaking?Closes #613