Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] signer/core: accept all solidity primitive types for EIP-712 signing … #5754

Closed
wants to merge 1 commit into from

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Aug 20, 2024

Cherry-picking ethereum/go-ethereum#26770

Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8


Co-authored-by: Martin Holst Swende martin@swende.se
(cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)

Important changes:

  • Something worth noting for reviewers.

Fixing status-im/status-desktop#15946

…(#26770)

Accept all primitive types in Solidity for EIP-712 from intN, uintN, intN[], uintN[] for N as 0 to 256 in multiples of 8

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
(cherry picked from commit 02796f6bee7e014fd16ad39f0bcd3b665b51e0bb)
@status-im-auto
Copy link
Member

status-im-auto commented Aug 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ b74d7ca #1 2024-08-20 18:27:12 ~54 sec tests 📄log
✔️ b74d7ca #1 2024-08-20 18:28:48 ~2 min tests-rpc 📄log
✔️ b74d7ca #1 2024-08-20 18:30:20 ~4 min linux 📦zip
✔️ b74d7ca #1 2024-08-20 18:30:36 ~4 min ios 📦zip
✔️ b74d7ca #1 2024-08-20 18:31:42 ~5 min android 📦aar
✖️ b74d7ca #2 2024-08-20 18:42:28 ~50 sec tests 📄log
✖️ b74d7ca #3 2024-08-20 18:46:13 ~39 sec tests 📄log

@alexjba
Copy link
Contributor Author

alexjba commented Aug 20, 2024

I'll update the fork

@alexjba alexjba closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants