Remove mocks for transaction manager and transaction queue #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divan
approved these changes
Jan 23, 2018
themue
approved these changes
Jan 26, 2018
geth/transactions/queue/queue.go
Outdated
| @@ -8,17 +8,14 @@ import ( | |||
|
|
|||
| "github.com/ethereum/go-ethereum/accounts/keystore" | |||
| gethcommon "github.com/ethereum/go-ethereum/common" | |||
| "github.com/status-im/status-go/geth/account" | |||
| "github.com/status-im/status-go/geth/common" | |||
| "github.com/status-im/status-go/geth/log" | |||
| ) | |||
|
|
|||
| const ( | |||
| // DefaultTxQueueCap defines how many items can be queued. | |||
| DefaultTxQueueCap = int(35) | |||
There was a problem hiding this comment.
Interesting. Isn't int the default here and casting only needed when explicitly wanting something like uint64 or similar.
geth/transactions/queue/queue.go
Outdated
| } | ||
|
|
||
| // LockInprogress returns transcation and locks it as inprogress | ||
| func (q *TxQueue) LockInprogress(id common.QueuedTxID) (*common.QueuedTx, error) { |
There was a problem hiding this comment.
LockInprogress() or LockInProgress()?
|
@dshulyak Will you take care of the conflicts, please? Thx. |
It is very unlikely that there will be 2 or more implementations of tx manager and queue, as they are tailored specifically to status project requirements.
dshulyak
force-pushed
the
removetxmock
branch
from
5243ddc to
b2ced14
Compare
|
@themue rebased, please consider merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unlikely that there will be 2 or more implementations of tx manager and queue, as they are tailored specifically to status project requirements.
Blocked by: #530