Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nph: format #17025

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

nph: format #17025

wants to merge 4 commits into from

Conversation

arnetheduck
Copy link
Member

The nph formatter is used by several projects at status already and is integrated with editors (vscode, nim language server, vim etc) - this PR shows what the code would look like.

The projects that use it also verify formatting in CI using a little action snippet. If there's interest, this can easily be set up for desktop as well.

@arnetheduck arnetheduck requested review from a team as code owners January 6, 2025 16:42
@arnetheduck arnetheduck requested review from dlipicar and Khushboo-dev-cpp and removed request for a team January 6, 2025 16:42
@arnetheduck arnetheduck marked this pull request as draft January 6, 2025 16:43
@jrainville
Copy link
Member

Nice. I'm all for a united formatting

@status-im-auto
Copy link
Member

status-im-auto commented Jan 6, 2025

Jenkins Builds

Click to see older builds (17)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4fff9f8 #1 2025-01-06 16:49:34 ~6 min macos/aarch64 🍎dmg
✔️ 4fff9f8 #1 2025-01-06 16:50:47 ~7 min tests/nim 📄log
4fff9f8 #1 2025-01-06 16:54:49 ~11 min tests/ui 📄log
✔️ 4fff9f8 #1 2025-01-06 17:01:49 ~18 min linux/x86_64 📦tgz
✔️ 4fff9f8 #1 2025-01-06 17:03:18 ~20 min macos/x86_64 🍎dmg
✔️ 4fff9f8 #1 2025-01-06 17:05:34 ~22 min windows/x86_64 💿exe
✔️ 4fff9f8 #1 2025-01-06 17:05:55 ~22 min linux-nix/x86_64 📦tgz
✔️ 9dc1ccc #2 2025-01-07 08:15:29 ~4 min macos/aarch64 🍎dmg
✔️ 9dc1ccc #2 2025-01-07 08:18:25 ~7 min tests/nim 📄log
✔️ 668d0d2 #3 2025-01-07 08:23:00 ~4 min macos/aarch64 🍎dmg
✔️ d72f40f #4 2025-01-07 08:31:11 ~8 min tests/nim 📄log
✔️ d72f40f #4 2025-01-07 08:31:19 ~8 min macos/aarch64 🍎dmg
✔️ d72f40f #4 2025-01-07 08:34:58 ~11 min tests/ui 📄log
✔️ d72f40f #4 2025-01-07 08:37:16 ~14 min macos/x86_64 🍎dmg
✔️ d72f40f #4 2025-01-07 08:39:15 ~16 min linux/x86_64 📦tgz
✔️ d72f40f #4 2025-01-07 08:40:41 ~17 min windows/x86_64 💿exe
✔️ d72f40f #4 2025-01-07 08:43:45 ~20 min linux-nix/x86_64 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
6b569ba #7 2025-01-07 18:06:58 ~4 min macos/aarch64 📄log
✖️ 6b569ba #7 2025-01-07 18:08:25 ~6 min tests/nim 📄log
6b569ba #7 2025-01-07 18:09:27 ~7 min linux-nix/x86_64 📄log
✔️ 6b569ba #7 2025-01-07 18:13:23 ~11 min tests/ui 📄log
6b569ba #7 2025-01-07 18:13:36 ~11 min linux/x86_64 📄log
6b569ba #7 2025-01-07 18:14:14 ~12 min macos/x86_64 📄log
6b569ba #7 2025-01-07 18:22:16 ~20 min windows/x86_64 📄log
e6fd0b4 #8 2025-01-07 20:09:19 ~3 min macos/aarch64 📄log
e6fd0b4 #8 2025-01-07 20:12:47 ~6 min linux-nix/x86_64 📄log
✖️ e6fd0b4 #8 2025-01-07 20:13:20 ~7 min tests/nim 📄log
e6fd0b4 #8 2025-01-07 20:15:54 ~9 min linux/x86_64 📄log
e6fd0b4 #8 2025-01-07 20:16:34 ~10 min macos/x86_64 📄log
✔️ e6fd0b4 #8 2025-01-07 20:18:00 ~11 min tests/ui 📄log
e6fd0b4 #8 2025-01-07 20:19:06 ~12 min windows/x86_64 📄log

@arnetheduck arnetheduck force-pushed the nph branch 2 times, most recently from 668d0d2 to d72f40f Compare January 7, 2025 08:22
The [`nph`](https://github.com/arnetheduck/nph) formatter is used by
several projects at status already and is integrated with editors
(vscode, nim language server, vim etc) - this PR shows what the code
would look like.

The projects that use it also verify formatting in CI using a little
action snippet. If there's interest, this can easily be set up for
desktop as well.
@arnetheduck arnetheduck closed this Jan 7, 2025
@arnetheduck arnetheduck reopened this Jan 7, 2025
@arnetheduck arnetheduck marked this pull request as ready for review January 7, 2025 18:01
@arnetheduck
Copy link
Member Author

@jrainville added the lint job - all yours from here.

@arnetheduck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants