-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nph: format #17025
Open
arnetheduck
wants to merge
4
commits into
master
Choose a base branch
from
nph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
nph: format #17025
+41,860
−26,646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
requested review from
dlipicar and
Khushboo-dev-cpp
and removed request for
a team
January 6, 2025 16:42
Nice. I'm all for a united formatting |
Jenkins BuildsClick to see older builds (17)
|
arnetheduck
force-pushed
the
nph
branch
2 times, most recently
from
January 7, 2025 08:22
668d0d2
to
d72f40f
Compare
The [`nph`](https://github.com/arnetheduck/nph) formatter is used by several projects at status already and is integrated with editors (vscode, nim language server, vim etc) - this PR shows what the code would look like. The projects that use it also verify formatting in CI using a little action snippet. If there's interest, this can easily be set up for desktop as well.
@jrainville added the lint job - all yours from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nph
formatter is used by several projects at status already and is integrated with editors (vscode, nim language server, vim etc) - this PR shows what the code would look like.The projects that use it also verify formatting in CI using a little action snippet. If there's interest, this can easily be set up for desktop as well.