refactor(messages): create a helper MessageItem init function #17008
+178
−398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
noeliaSD,
Cuteivist,
igor-sirotin and
osmaczko
and removed request for
a team and
noeliaSD
Jenkins BuildsClick to see older builds (14)
|
igor-sirotin
approved these changes
Jan 6, 2025
| @@ -7,7 +7,7 @@ import ../item as chat_item | |||
| import ./chat_details | |||
| import ../../../shared_models/message_model as pinned_msg_model | |||
| import ../../../shared_models/message_item as pinned_msg_item | |||
| import ../../../shared_models/message_transaction_parameters_item | |||
| # import ../../../shared_models/message_transaction_parameters_item | |||
jrainville
force-pushed
the
refactor/single-message-item-creation-proc
branch
from
9880cb1 to
72bfa67
Compare
jrainville
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
jrainville
requested review from
virginiabalducci
and removed request for
a team
jrainville
force-pushed
the
fix/old-pins-looking-normal
branch
from
666b15b to
c71a9ef
Compare
jrainville
force-pushed
the
refactor/single-message-item-creation-proc
branch
from
72bfa67 to
664e06e
Compare
caybro
reviewed
Jan 6, 2025
src/app/modules/main/chat_section/chat_content/messages/module.nim
Outdated
Show resolved
Hide resolved
jrainville
force-pushed
the
fix/old-pins-looking-normal
branch
from
c71a9ef to
cdeaf56
Compare
jrainville
force-pushed
the
refactor/single-message-item-creation-proc
branch
from
664e06e to
4c18af4
Compare
caybro
approved these changes
Jan 6, 2025
|
@alexjba you are the randomly selected tester. In this case, just check that the messages work nicely everywhere and will all types of messages |
Fixes #14039 Creates a util function to create MessageItems.
jrainville
force-pushed
the
refactor/single-message-item-creation-proc
branch
from
4c18af4 to
d45dc96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14039
Creates a util function to create MessageItems.
Based on top of #16894 because it modified the
initMessageItemfunction so I wanted to avoid conflicts