Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplicate of creating message item #14039

Closed
mprakhov opened this issue Mar 19, 2024 · 0 comments · Fixed by #17008
Closed

Remove code duplicate of creating message item #14039

mprakhov opened this issue Mar 19, 2024 · 0 comments · Fixed by #17008
Assignees
@jrainville
Labels
core-team refactor
Milestone
2.33.0 Beta

Comments

@mprakhov
Copy link
Contributor

Description

We have duplicate code of creating message Item (shared_models/message_item) in modeles for

  1. chat_section - buildCommunityMemberMessageItem
  2. chat_content - buildPinnedMessageItem
  3. messages - createMessageItemsFromMessageDtos

We need to create a common fn to convert from messageDTO to Item and reuse this fn in all this modules
@mprakhov mprakhov mentioned this issue Mar 19, 2024
Merged
@jrainville jrainville added this to the 2.32.0 Beta milestone Aug 26, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@jrainville jrainville self-assigned this Dec 23, 2024
@jrainville jrainville moved this from Next to In Progress in Status Desktop/Mobile Board Dec 23, 2024
jrainville added a commit that referenced this issue Dec 23, 2024
@jrainville
refactor(messages): create a helper MessageItem init function
9880cb1 
Fixes #14039

Creates a util function to create MessageItems.
@jrainville jrainville mentioned this issue Dec 23, 2024
Merged
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Dec 23, 2024
jrainville added a commit that referenced this issue Jan 6, 2025
@jrainville
refactor(messages): create a helper MessageItem init function
72bfa67 
Fixes #14039

Creates a util function to create MessageItems.
jrainville added a commit that referenced this issue Jan 6, 2025
@jrainville
refactor(messages): create a helper MessageItem init function
664e06e 
Fixes #14039

Creates a util function to create MessageItems.
jrainville added a commit that referenced this issue Jan 6, 2025
@jrainville
refactor(messages): create a helper MessageItem init function
4c18af4 
Fixes #14039

Creates a util function to create MessageItems.
jrainville added a commit that referenced this issue Jan 8, 2025
@jrainville
refactor(messages): create a helper MessageItem init function
d45dc96 
Fixes #14039

Creates a util function to create MessageItems.
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

Labels
core-team refactor
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

refactor(messages): create a helper MessageItem init function status-im/status-desktop
3 participants
@iurimatias @jrainville @mprakhov